giles
88f8b427c5
Reported: go to an edit page, then press Home — nothing happens; navigation stops updating.
Root cause (found via a browser trace): a guarded route (host/require-login) answered a
BOOSTED (SX-Request) request with a 303 to /login. The browser's fetch follows the redirect
but DROPS the SX-Request header on the way, so /login returned the full HTML shell (<!doctype
html>…), not a text/sx fragment. Morphing that whole document into #content DESTROYS the
#content swap target (diagnostic: "#content count: 0"), so every later boosted nav fetches
but has nowhere to swap ("post-swap: root=nil") — the persistent nav Home appears to do
nothing.
Fix (host-side, no engine change — the engine already supports SX-Redirect): for a boosted
request require-login now returns 200 + an `SX-Redirect: /login?next=…` header. The engine
does a FULL navigation (browser-navigate) to a real /login page — #content is never
clobbered. Non-boosted requests still get a plain 303. Also added a "← Home" link to the
login shell (it's a standalone page with no persistent nav, so a logged-out user who followed
a guarded link was otherwise stranded — the literal "press Home" case).
TEST-FIRST: added a second boost-nav.spec.js case (home → post → click edit → assert clean
full-nav to /login, NOT a clobbered SPA, and Home works from there). Confirmed RED before
(Home did nothing on the clobbered page), GREEN after — verified on the ephemeral server AND
live. No regressions: picker 3/3 + block-editor 1/1 (login flow intact).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
60 lines
3.2 KiB
JavaScript
60 lines
3.2 KiB
JavaScript
// Regression for the boosted-navigation link-rebinding bug (reported on blog.rose-ash.com):
|
|
// home --boosted nav--> a post --click "edit"--> lands on /tags (a HOME footer link),
|
|
// not /<slug>/edit. After a boost swap, the swapped-in links carry a STALE binding from
|
|
// the previous page. Run by run-boost-nav-check.sh against an ephemeral host server
|
|
// (serve.sh seeds /compose-demo + the home footer's /tags link).
|
|
const { test, expect } = require('playwright/test');
|
|
|
|
const BASE = process.env.SX_TEST_URL || 'http://127.0.0.1:8914';
|
|
|
|
async function waitReady(page) {
|
|
await expect(page.locator('html[data-sx-ready="true"]')).toHaveCount(1, { timeout: 45000 });
|
|
}
|
|
|
|
test.describe('boosted navigation (browser-only)', () => {
|
|
test('a post link clicked AFTER a boosted nav navigates to the right target (not a stale home link)', async ({ page }) => {
|
|
test.setTimeout(90000);
|
|
// 1) load HOME (its footer has a /tags link — the stale target the bug lands on)
|
|
await page.goto(BASE + '/');
|
|
await waitReady(page);
|
|
await expect(page.locator('a[href="/tags"]')).toHaveCount(1); // home has the /tags link
|
|
|
|
// 2) boosted nav HOME -> the composed post (no full reload)
|
|
await page.locator('a[href="/compose-demo/"]').first().click();
|
|
await expect(page.locator('body')).toContainText('composition object', { timeout: 15000 });
|
|
expect(page.url()).toContain('/compose-demo/');
|
|
|
|
// 3) click the post's "edit" link — brought in by the swap
|
|
await expect(page.locator('a[href="/compose-demo/edit"]')).toHaveCount(1);
|
|
await page.locator('a[href="/compose-demo/edit"]').click();
|
|
await page.waitForTimeout(3000);
|
|
|
|
// 4) it MUST navigate to the edit route (guarded -> the login view is fine, the URL is
|
|
// pushed to /compose-demo/edit), and MUST NOT land on the stale /tags link.
|
|
expect(page.url()).not.toContain('/tags');
|
|
expect(page.url()).toContain('/compose-demo/edit');
|
|
});
|
|
|
|
test('a guarded route reached via boost does a clean full-nav to /login (no clobbered SPA), and Home works from there', async ({ page }) => {
|
|
test.setTimeout(90000);
|
|
await page.goto(BASE + '/');
|
|
await waitReady(page);
|
|
// boosted nav home -> post
|
|
await page.locator('a[href="/compose-demo/"]').first().click();
|
|
await expect(page.locator('body')).toContainText('composition object', { timeout: 15000 });
|
|
// click "edit" (guarded, logged out). A 303 would be followed by the fetch WITHOUT the
|
|
// SX-Request header -> /login returns the full shell, which morphed into #content
|
|
// DESTROYS the swap target (then nothing navigates). The fix returns SX-Redirect, so the
|
|
// engine does a FULL navigation to a real /login page.
|
|
await page.locator('a[href="/compose-demo/edit"]').click();
|
|
await page.waitForTimeout(3500);
|
|
expect(new URL(page.url()).pathname).toBe('/login');
|
|
await expect(page.locator('body')).toContainText('Log in');
|
|
// and the login page offers a way back Home that works (the reported "Home does nothing").
|
|
await page.locator('a[href="/"]').first().click();
|
|
await page.waitForTimeout(3000);
|
|
await expect(page.locator('body')).toContainText('Posts', { timeout: 12000 });
|
|
expect(new URL(page.url()).pathname).toBe('/');
|
|
});
|
|
});
|