coop/rose-ash
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix polling interval leak on SPA navigation

Browse Source 
The poll trigger in bind-triggers called set-interval but discarded the
interval ID, so polls continued firing after the element was removed from
the DOM. Now the callback checks el.isConnected each tick and self-clears
when the element is gone (HTMX-style cleanup).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
giles
2026-04-01 16:44:57 +00:00
parent d1b49db057
commit f5f58ea47e
3 changed files with 30 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
shared/static/wasm/sx/orchestration.sx
View File

@@ -410,9 +410,20 @@
(mods (get trigger "modifiers")))
(cond
(= kind "poll")
(set-interval
(fn () (execute-request el nil nil))
(get mods "interval"))
(let
((interval-id nil))
(set!
interval-id
(set-interval
(fn
()
(if
(host-get el "isConnected")
(execute-request el nil nil)
(do
(clear-interval interval-id)
(log-info "poll stopped: element removed"))))
(get mods "interval"))))
(= kind "intersect")
(observe-intersection
el

4
shared/static/wasm/sx/orchestration.sxbc
View File

File diff suppressed because one or more lines are too long

17
web/orchestration.sx
View File

@@ -410,9 +410,20 @@
(mods (get trigger "modifiers")))
(cond
(= kind "poll")
(set-interval
(fn () (execute-request el nil nil))
(get mods "interval"))
(let
((interval-id nil))
(set!
interval-id
(set-interval
(fn
()
(if
(host-get el "isConnected")
(execute-request el nil nil)
(do
(clear-interval interval-id)
(log-info "poll stopped: element removed"))))
(get mods "interval"))))
(= kind "intersect")
(observe-intersection
el