coop/rose-ash
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix examples.sx: paren balance + dict eval crash at startup

Browse Source 
1. Extra closing paren in ex-tabs handler
2. tab-content dict values contained (div ...) HTML tags which crash
   during register_components since HTML primitives aren't in env

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
giles
2026-03-12 01:30:21 +00:00
parent c23d0888ea
commit 17c58a2b5b
10 changed files with 110 additions and 1103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

367
sx/sxc/handlers/examples.sx
View File

@@ -1,367 +0,0 @@
;; SX example API handlers — defhandler definitions
;;
;; These serve the live demos on the Examples docs pages.
;; Each handler's source is displayed in the "Server handler" code block
;; on its corresponding example page (self-referencing via handler-source).
;; ---------------------------------------------------------------------------
;; Click to Load
;; ---------------------------------------------------------------------------
(defhandler click (&key)
(let ((now (format-time (now) "%H:%M:%S")))
(~click-result :time now)))
;; ---------------------------------------------------------------------------
;; Form Submission
;; ---------------------------------------------------------------------------
(defhandler form (&key)
(let ((name (form-data "name")))
(~form-result :name name)))
;; ---------------------------------------------------------------------------
;; Polling
;; ---------------------------------------------------------------------------
(defhandler poll (&key)
(let ((now (format-time (now) "%H:%M:%S"))
(count (inc-counter "poll" :max 10)))
(~poll-result :time now :count count)))
;; ---------------------------------------------------------------------------
;; Delete Row
;; ---------------------------------------------------------------------------
(defhandler delete (&key item-id)
;; Empty response — outerHTML swap removes the row
"")
;; ---------------------------------------------------------------------------
;; Inline Edit
;; ---------------------------------------------------------------------------
(defhandler edit-form (&key)
(let ((value (request-arg "value")))
(~inline-edit-form :value value)))
(defhandler edit-save (&key)
(let ((value (form-data "value")))
(~inline-view :value value)))
(defhandler edit-cancel (&key)
(let ((value (request-arg "value")))
(~inline-view :value value)))
;; ---------------------------------------------------------------------------
;; Out-of-Band Swaps
;; ---------------------------------------------------------------------------
(defhandler oob (&key)
(let ((now (format-time (now) "%H:%M:%S")))
(<>
(p :class "text-emerald-600 font-medium" "Box A updated!")
(p :class "text-sm text-stone-500" "at " now)
(div :id "oob-box-b" :sx-swap-oob "innerHTML"
(p :class "text-violet-600 font-medium" "Box B updated via OOB!")
(p :class "text-sm text-stone-500" "at " now)))))
;; ---------------------------------------------------------------------------
;; Lazy Loading
;; ---------------------------------------------------------------------------
(defhandler lazy (&key)
(let ((now (format-time (now) "%H:%M:%S")))
(~lazy-result :time now)))
;; ---------------------------------------------------------------------------
;; Infinite Scroll
;; ---------------------------------------------------------------------------
(defhandler scroll (&key)
(let ((page (or (parse-int (request-arg "page")) 2))
(start (+ (* (- page 1) 5) 1))
(next (+ page 1)))
(<>
(map (fn (i)
(div :class "px-4 py-3 border-b border-stone-100 text-sm text-stone-700"
"Item " i " — loaded from page " page))
(range start (+ start 5)))
(if (<= next 6)
(div :id "scroll-sentinel"
:sx-get (str "/geography/hypermedia/examples/api/scroll?page=" next)
:sx-trigger "intersect once"
:sx-target "#scroll-items"
:sx-swap "beforeend"
:class "p-3 text-center text-stone-400 text-sm"
"Loading more...")
(div :class "p-3 text-center text-stone-500 text-sm font-medium"
"All items loaded.")))))
;; ---------------------------------------------------------------------------
;; Progress Bar
;; ---------------------------------------------------------------------------
(defhandler progress-start (&key)
(let ((job-id (new-job)))
(~progress-status :percent 0 :job-id job-id)))
(defhandler progress-status (&key)
(let ((job-id (request-arg "job"))
(percent (advance-job job-id)))
(~progress-status :percent percent :job-id job-id)))
;; ---------------------------------------------------------------------------
;; Active Search
;; ---------------------------------------------------------------------------
(defhandler search (&key)
(let ((q (request-arg "q"))
(results (filter-list LANGUAGES q)))
(~search-results :items results :query q)))
;; ---------------------------------------------------------------------------
;; Inline Validation
;; ---------------------------------------------------------------------------
(defhandler validate (&key)
(let ((email (request-arg "email")))
(cond
((not email)
(~validation-error :message "Email is required"))
((not (contains? email "@"))
(~validation-error :message "Invalid email format"))
((contains? TAKEN_EMAILS (lower email))
(~validation-error
:message (str email " is already taken")))
(t (~validation-ok :email email)))))
;; ---------------------------------------------------------------------------
;; Value Select
;; ---------------------------------------------------------------------------
(defhandler values (&key)
(let ((cat (request-arg "category"))
(items (get VALUE_SELECT_DATA cat)))
(if (empty? items)
(option :value "" "No items")
(map (fn (i) (option :value i i)) items))))
;; ---------------------------------------------------------------------------
;; Reset on Submit
;; ---------------------------------------------------------------------------
(defhandler reset-submit (&key)
(let ((msg (or (form-data "message") "(empty)"))
(now (format-time (now) "%H:%M:%S")))
(~reset-message :message msg :time now)))
;; ---------------------------------------------------------------------------
;; Edit Row
;; ---------------------------------------------------------------------------
(defhandler editrow-form (&key row-id)
(let ((row (get ROWS row-id)))
(~edit-row-form :id row-id
:name (get row "name")
:price (get row "price")
:stock (get row "stock"))))
(defhandler editrow-save (&key row-id)
(let ((name (form-data "name"))
(price (form-data "price"))
(stock (form-data "stock")))
(~edit-row-view :id row-id
:name name :price price :stock stock)))
(defhandler editrow-cancel (&key row-id)
(let ((row (get ROWS row-id)))
(~edit-row-view :id row-id
:name (get row "name")
:price (get row "price")
:stock (get row "stock"))))
;; ---------------------------------------------------------------------------
;; Bulk Update
;; ---------------------------------------------------------------------------
(defhandler bulk (&key)
(let ((action (request-arg "action"))
(ids (form-list "ids"))
(status (if (= action "activate")
"active" "inactive")))
(update-users ids :status status)
(map (fn (u)
(~bulk-row
:id (get u "id")
:name (get u "name")
:email (get u "email")
:status (get u "status")))
USERS)))
;; ---------------------------------------------------------------------------
;; Swap Positions
;; ---------------------------------------------------------------------------
(defhandler swap-log (&key)
(let ((mode (request-arg "mode"))
(n (inc-counter "swap"))
(now (format-time (now) "%H:%M:%S")))
(<>
(div :class "px-3 py-2 text-sm text-stone-700"
"[" now "] " mode " (#" n ")")
(span :id "swap-counter"
:sx-swap-oob "innerHTML"
:class "self-center text-sm text-stone-500"
"Count: " n))))
;; ---------------------------------------------------------------------------
;; Select Filter (Dashboard)
;; ---------------------------------------------------------------------------
(defhandler dashboard (&key)
(let ((now (format-time (now) "%H:%M:%S")))
(<>
(div :id "dash-header" :class "p-3 bg-violet-50 rounded mb-3"
(h4 :class "font-semibold text-violet-800" "Dashboard Header")
(p :class "text-sm text-violet-600" "Generated at " now))
(div :id "dash-stats" :class "grid grid-cols-3 gap-3 mb-3"
(div :class "p-3 bg-emerald-50 rounded text-center"
(p :class "text-2xl font-bold text-emerald-700" "142")
(p :class "text-xs text-emerald-600" "Users"))
(div :class "p-3 bg-blue-50 rounded text-center"
(p :class "text-2xl font-bold text-blue-700" "89")
(p :class "text-xs text-blue-600" "Orders"))
(div :class "p-3 bg-amber-50 rounded text-center"
(p :class "text-2xl font-bold text-amber-700" "$4.2k")
(p :class "text-xs text-amber-600" "Revenue")))
(div :id "dash-footer" :class "p-3 bg-stone-100 rounded"
(p :class "text-sm text-stone-500" "Last updated: " now)))))
;; ---------------------------------------------------------------------------
;; Tabs
;; ---------------------------------------------------------------------------
(defhandler tabs (&key tab)
(let ((content (get TAB_CONTENT tab)))
(<> content
(div :id "tab-buttons"
:sx-swap-oob "innerHTML"
:class "flex border-b border-stone-200"
(map (fn (t)
(~tab-btn
:tab (first t)
:label (last t)
:active (if (= (first t) tab) "true" "false")))
TAB_LIST)))))
;; ---------------------------------------------------------------------------
;; Animations
;; ---------------------------------------------------------------------------
(defhandler animate (&key)
(let ((color (random-choice
"bg-violet-100" "bg-emerald-100"
"bg-blue-100" "bg-amber-100"))
(now (format-time (now) "%H:%M:%S")))
(~anim-result :color color :time now)))
;; ---------------------------------------------------------------------------
;; Dialogs
;; ---------------------------------------------------------------------------
(defhandler dialog (&key)
(~dialog-modal
:title "Confirm Action"
:message "Are you sure you want to proceed?"))
(defhandler dialog-close (&key)
"")
;; ---------------------------------------------------------------------------
;; Keyboard Shortcuts
;; ---------------------------------------------------------------------------
(defhandler keyboard (&key)
(let ((key (request-arg "key"))
(actions {:s "Search panel activated"
:n "New item created"
:h "Help panel opened"})
(action (get actions key)))
(~kbd-result :key key :action action)))
;; ---------------------------------------------------------------------------
;; PUT / PATCH
;; ---------------------------------------------------------------------------
(defhandler pp-edit-all (&key)
(let ((p (get-profile)))
(~pp-form-full
:name (get p "name")
:email (get p "email")
:role (get p "role"))))
(defhandler put-profile (&key)
(let ((name (form-data "name"))
(email (form-data "email"))
(role (form-data "role")))
(~pp-view :name name :email email :role role)))
(defhandler pp-cancel (&key)
(let ((p (get-profile)))
(~pp-view
:name (get p "name")
:email (get p "email")
:role (get p "role"))))
;; ---------------------------------------------------------------------------
;; JSON Encoding
;; ---------------------------------------------------------------------------
(defhandler json-echo (&key)
(let ((data (request-json))
(body (json-pretty data))
(ct (request-header "content-type")))
(~json-result :body body :content-type ct)))
;; ---------------------------------------------------------------------------
;; Vals & Headers
;; ---------------------------------------------------------------------------
(defhandler echo-vals (&key)
(let ((vals (request-args)))
(~echo-result :label "values" :items vals)))
(defhandler echo-headers (&key)
(let ((headers (request-headers :prefix "X-")))
(~echo-result :label "headers" :items headers)))
;; ---------------------------------------------------------------------------
;; Loading States
;; ---------------------------------------------------------------------------
(defhandler slow (&key)
(sleep 2000)
(let ((now (format-time (now) "%H:%M:%S")))
(~loading-result :time now)))
;; ---------------------------------------------------------------------------
;; Request Abort (sync replace)
;; ---------------------------------------------------------------------------
(defhandler slow-search (&key)
(let ((delay (random-int 500 2000)))
(sleep delay)
(let ((q (request-arg "q")))
(~sync-result :query q :delay delay))))
;; ---------------------------------------------------------------------------
;; Retry
;; ---------------------------------------------------------------------------
(defhandler flaky (&key)
(let ((n (inc-counter "flaky")))
(if (!= (mod n 3) 0)
(error 503)
(~retry-result :attempt n
:message "Success! The endpoint finally responded."))))

30
sx/sxc/pages/helpers.py
View File

@@ -35,6 +35,7 @@ def _register_sx_helpers() -> None:
"prove-data": _prove_data,
"page-helpers-demo-data": _page_helpers_demo_data,
"spec-explorer-data": _spec_explorer_data,
"handler-source": _handler_source,
})
@@ -68,6 +69,35 @@ def _component_source(name: str) -> str:
})
def _handler_source(name: str) -> str:
"""Return the pretty-printed defhandler source for a named handler."""
from shared.sx.handlers import get_handler
from shared.sx.parser import serialize
hdef = get_handler("sx", name)
if not hdef:
return f";;; Handler not found: {name}"
parts = [f"(defhandler {hdef.name}"]
if hdef.path:
parts.append(f' :path "{hdef.path}"')
if hdef.method != "get":
parts.append(f" :method :{hdef.method}")
if not hdef.csrf:
parts.append(" :csrf false")
if hdef.returns != "element":
parts.append(f' :returns "{hdef.returns}"')
param_strs = ["&key"] + list(hdef.params) if hdef.params else []
parts.append(f" ({' '.join(param_strs)})" if param_strs else " ()")
body_sx = serialize(hdef.body, pretty=True)
# Indent body by 2 spaces
body_lines = body_sx.split("\n")
parts.append(" " + body_lines[0])
for line in body_lines[1:]:
parts.append(" " + line)
return "\n".join(parts) + ")"
def _primitives_data() -> dict:
"""Return the PRIMITIVES dict for the primitives docs page."""
from content.pages import PRIMITIVES