coop/shared
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename product blueprint URL param slug → product_slug in templates

Browse Source 
Avoids collision with app-level url_value_preprocessor that pops
"slug" for page-level routing. All url_for() calls for product
endpoints now use product_slug= instead of slug=.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
giles
2026-02-24 10:24:49 +00:00
parent 2a9dfaa749
commit 0d40dfaeca
6 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
browser/templates/_types/browse/_admin.html
View File

@@ -2,6 +2,6 @@
{% if g.rights.admin %} {% if g.rights.admin %}
{% from 'macros/admin_nav.html' import admin_nav_item %} {% from 'macros/admin_nav.html' import admin_nav_item %}
{{admin_nav_item( {{admin_nav_item(
url_for('market.browse.product.admin', slug=slug) url_for('market.browse.product.admin', product_slug=slug)
)}} )}}
{% endif %} {% endif %}

2
browser/templates/_types/browse/_product_card.html
View File

@@ -2,7 +2,7 @@
{% import '_types/product/prices.html' as prices %} {% import '_types/product/prices.html' as prices %}
{% set prices_ns = namespace() %} {% set prices_ns = namespace() %}
{{ prices.set_prices(p, prices_ns) }} {{ prices.set_prices(p, prices_ns) }}
{% set item_href = url_for('market.browse.product.product_detail', slug=p.slug)|host %} {% set item_href = url_for('market.browse.product.product_detail', product_slug=p.slug)|host %}
<div class="flex flex-col rounded-xl bg-white shadow hover:shadow-md transition overflow-hidden relative"> <div class="flex flex-col rounded-xl bg-white shadow hover:shadow-md transition overflow-hidden relative">
{# ❤️ like button overlay - OUTSIDE the link #} {# ❤️ like button overlay - OUTSIDE the link #}
{% if g.user %} {% if g.user %}

2
browser/templates/_types/browse/like/button.html
View File

@@ -1,6 +1,6 @@
<button <button
class="flex items-center gap-1 {% if liked %} text-red-600 {% else %} text-stone-300 {% endif %} hover:text-red-600 transition-colors w-[1em] h-[1em]" class="flex items-center gap-1 {% if liked %} text-red-600 {% else %} text-stone-300 {% endif %} hover:text-red-600 transition-colors w-[1em] h-[1em]"
hx-post="{{ like_url if like_url else url_for('market.browse.product.like_toggle', slug=slug)|host }}" hx-post="{{ like_url if like_url else url_for('market.browse.product.like_toggle', product_slug=slug)|host }}"
hx-target="this" hx-target="this"
hx-swap="outerHTML" hx-swap="outerHTML"
hx-push-url="false" hx-push-url="false"

2
browser/templates/_types/product/admin/header/_header.html
View File

@@ -1,7 +1,7 @@
{% import 'macros/links.html' as links %} {% import 'macros/links.html' as links %}
{% macro header_row(oob=False) %} {% macro header_row(oob=False) %}
{% call links.menu_row(id='product-admin-row', oob=oob) %} {% call links.menu_row(id='product-admin-row', oob=oob) %}
{% call links.link(url_for('market.browse.product.admin', slug=d.slug), hx_select_search ) %} {% call links.link(url_for('market.browse.product.admin', product_slug=d.slug), hx_select_search ) %}
admin!! admin!!
{% endcall %} {% endcall %}
{% call links.desktop_nav() %} {% call links.desktop_nav() %}

2
browser/templates/_types/product/admin/index.html
View File

@@ -15,7 +15,7 @@
{% block ___app_title %} {% block ___app_title %}
{% import 'macros/links.html' as links %} {% import 'macros/links.html' as links %}
{% call links.menu_row() %} {% call links.menu_row() %}
{% call links.link(url_for('market.browse.product.admin', slug=slug), hx_select_search) %} {% call links.link(url_for('market.browse.product.admin', product_slug=slug), hx_select_search) %}
{{ links.admin() }} {{ links.admin() }}
{% endcall %} {% endcall %}
{% call links.desktop_nav() %} {% call links.desktop_nav() %}

2
browser/templates/_types/product/header/_header.html
View File

@@ -1,7 +1,7 @@
{% import 'macros/links.html' as links %} {% import 'macros/links.html' as links %}
{% macro header_row(oob=False) %} {% macro header_row(oob=False) %}
{% call links.menu_row(id='product-row', oob=oob) %} {% call links.menu_row(id='product-row', oob=oob) %}
{% call links.link(url_for('market.browse.product.product_detail', slug=d.slug), hx_select_search ) %} {% call links.link(url_for('market.browse.product.product_detail', product_slug=d.slug), hx_select_search ) %}
{% include '_types/product/_title.html' %} {% include '_types/product/_title.html' %}
{% endcall %} {% endcall %}
{% include '_types/product/_prices.html' %} {% include '_types/product/_prices.html' %}