giles
f1bd6f1557
Some checks failed
Test, Build, and Deploy / test-build-deploy (push) Failing after 40s
Fixes "the remove button does nothing — no network, no console". A plain form on a boosted (sx-boost) page has no sx-get/sx-post, so the SPA engine boosts it and binds submit -> execute-request. But bind-boost-form called `(execute-request form nil nil)` — discarding the method+action it was handed — and execute-request then asks get-verb-info for a verb, gets nil, and no-ops. So EVERY plain boosted form silently did nothing: the related-posts "remove" button, the editor Save button, the is-a-tag toggle. Fix: pass the form's own method+action as the verbInfo `(dict "method" method "url" action)`, so the request actually fires (body built from the form fields). A latent web-engine bug surfaced by the host's edit page — the first page with plain boosted POST forms. Test: relate-picker.spec.js gains a remove-button case (relate, reload, click remove, assert the relation is gone) — 7/7. WASM rebuilt (boot-helpers.sxbc). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
152 lines
8.5 KiB
JavaScript
152 lines
8.5 KiB
JavaScript
// Browser check for the relate picker (lib/host/blog.sx). Runs against an
|
|
// ephemeral host server seeded with a host post + 25 candidates by
|
|
// run-picker-check.sh, which copies this spec into the Playwright env and sets
|
|
// SX_TEST_URL. The picker is a DECLARATIVE SX-htmx form (no client JS): the form
|
|
// GETs /<slug>/relate-options on "load" and on a debounced "input", swapping the
|
|
// results <ul>; a full page carries a "load more" sentinel that pages on reveal.
|
|
// Exercises the login redirect, the initial populate, debounced filter, infinite
|
|
// scroll, click-to-relate, AND populate after a boosted SPA nav (the case the old
|
|
// inline <script> picker silently failed — a script never runs on swapped content).
|
|
const { test, expect } = require('playwright/test');
|
|
|
|
const USER = process.env.SX_ADMIN_USER || 'admin';
|
|
const PASS = process.env.SX_ADMIN_PASSWORD || 'letmein';
|
|
const HOST = 'picker-host'; // the post whose edit page we drive
|
|
const LIMIT = 20; // host/blog--picker-limit (one page)
|
|
// the Related picker box (the edit page now has one picker per kind)
|
|
const REL = '.relate-picker[data-kind="related"]';
|
|
const RELF = `${REL} .rp-filter`;
|
|
const RELR = `${REL} .rp-results`;
|
|
const RELROWS = `${RELR} li:not(.rp-more)`; // candidate rows (exclude the sentinel)
|
|
const MORE = `${RELR} .rp-more`; // the load-more sentinel
|
|
|
|
// boot-init marks <html data-sx-ready="true"> once the WASM kernel + web stack
|
|
// load. WASM compile + asset fetches, so allow generous time.
|
|
async function waitReady(page) {
|
|
await expect(page.locator('html[data-sx-ready="true"]')).toHaveCount(1, { timeout: 45000 });
|
|
}
|
|
|
|
// Navigate to a GUARDED path; the host redirects to /login?next=…, so fill the
|
|
// form and we should land back on the original path (exercises the auth flow).
|
|
async function loginTo(page, path) {
|
|
await page.goto(path);
|
|
await page.waitForURL(/\/login/);
|
|
await page.fill('input[name="username"]', USER);
|
|
await page.fill('input[name="password"]', PASS);
|
|
await page.click('button[type="submit"]');
|
|
await page.waitForURL((u) => !u.pathname.startsWith('/login'));
|
|
}
|
|
|
|
// Log in directly (for reaching PUBLIC pages while authenticated).
|
|
async function login(page) {
|
|
await page.goto('/login');
|
|
await page.fill('input[name="username"]', USER);
|
|
await page.fill('input[name="password"]', PASS);
|
|
await page.click('button[type="submit"]');
|
|
await page.waitForURL((u) => !u.pathname.startsWith('/login'));
|
|
}
|
|
|
|
test.describe('relate picker', () => {
|
|
test('edit page has Related + Tags pickers and an is-a-tag toggle', async ({ page }) => {
|
|
await loginTo(page, `/${HOST}/edit`);
|
|
await expect(page).toHaveURL(new RegExp(`/${HOST}/edit`));
|
|
await expect(page.locator(RELF)).toBeVisible(); // Related picker
|
|
await expect(page.locator('.relate-picker[data-kind="tagged"] .rp-filter')).toBeVisible(); // Tags picker
|
|
await expect(page.getByRole('button', { name: 'Make this a tag' })).toBeVisible(); // toggle
|
|
});
|
|
|
|
test('picker populates on load and pages via the load-more sentinel', async ({ page }) => {
|
|
await loginTo(page, `/${HOST}/edit`);
|
|
await waitReady(page); // wait for the WASM kernel before the picker's "load" fires
|
|
const rows = page.locator(RELROWS);
|
|
// the declarative form's "load" trigger fills the first page (the populate fix)
|
|
await expect.poll(() => rows.count(), { timeout: 10000 }).toBeGreaterThanOrEqual(LIMIT);
|
|
// there are more candidates than one page, so reveal the sentinel (if it hasn't
|
|
// already auto-revealed) to page in the rest — robust to the exact total and to
|
|
// the sentinel starting above or below the fold.
|
|
const more = page.locator(MORE);
|
|
if (await more.count()) await more.first().scrollIntoViewIfNeeded();
|
|
await expect.poll(() => rows.count(), { timeout: 10000 }).toBeGreaterThan(LIMIT); // paged in more
|
|
});
|
|
|
|
test('typing in the filter narrows the candidates', async ({ page }) => {
|
|
await loginTo(page, `/${HOST}/edit`);
|
|
await waitReady(page);
|
|
await expect.poll(() => page.locator(RELROWS).count(), { timeout: 10000 }).toBeGreaterThan(0);
|
|
await page.fill(RELF, 'Item 13');
|
|
await expect.poll(() => page.locator(RELROWS).count(), { timeout: 10000 }).toBe(1);
|
|
await expect(page.locator(RELR)).toContainText('Picker Item 13');
|
|
});
|
|
|
|
test('clicking a candidate relates it and removes just that row (no reload)', async ({ page }) => {
|
|
test.setTimeout(75000);
|
|
await loginTo(page, `/${HOST}/edit`);
|
|
await waitReady(page);
|
|
await page.fill(RELF, 'Item 07');
|
|
await expect.poll(() => page.locator(RELROWS).count(), { timeout: 10000 }).toBe(1);
|
|
// sentinel survives ONLY if there is no full-page reload
|
|
await page.evaluate(() => { window.__noReload = true; });
|
|
await page.locator(`${RELROWS} button`).first().click();
|
|
// the AJAX relate deletes just that candidate row in place — no reload, no
|
|
// candidate-list refetch
|
|
await expect.poll(() => page.locator(RELROWS).count(), { timeout: 10000 }).toBe(0);
|
|
expect(await page.evaluate(() => window.__noReload)).toBe(true);
|
|
// and the relation actually persisted (shows on the public post page)
|
|
await page.goto(`/${HOST}/`);
|
|
await expect(page.getByRole('heading', { name: 'Related posts' })).toBeVisible();
|
|
await expect(page.locator('body')).toContainText('Picker Item 07');
|
|
});
|
|
|
|
test('the remove button on a current relation actually unrelates it', async ({ page }) => {
|
|
test.setTimeout(75000);
|
|
await loginTo(page, `/${HOST}/edit`);
|
|
await waitReady(page);
|
|
// relate Item 13 via the picker, then reload so it shows in the current list
|
|
await page.fill(RELF, 'Item 13');
|
|
await expect.poll(() => page.locator(RELROWS).count(), { timeout: 10000 }).toBe(1);
|
|
await page.locator(`${RELROWS} button`).first().click();
|
|
await expect.poll(() => page.locator(RELROWS).count(), { timeout: 10000 }).toBe(0);
|
|
await page.reload();
|
|
await waitReady(page);
|
|
const relLink = page.locator('a[href="/picker-item-13/"]');
|
|
await expect(relLink).toHaveCount(1); // current relation present
|
|
// click its remove button — a plain boosted form (regression: this did nothing
|
|
// because bind-boost-form discarded the form's method/action)
|
|
await page.locator('li:has(a[href="/picker-item-13/"]) button').click();
|
|
await expect(relLink).toHaveCount(0, { timeout: 12000 }); // relation removed
|
|
});
|
|
|
|
test('picker populates after a boosted SPA nav to the edit page', async ({ page }) => {
|
|
// Reach the edit page by CLICKING its link (a boosted SPA nav), not page.goto.
|
|
// The old inline <script> picker never ran on swapped-in content, so the list
|
|
// stayed empty here. The declarative form's "load" trigger is re-bound by the
|
|
// engine on swap, so it populates — that's the regression this guards.
|
|
await login(page);
|
|
await page.goto(`/${HOST}/`); // public post page, logged in
|
|
await waitReady(page);
|
|
await page.evaluate(() => { window.__noReload = true; });
|
|
await page.locator(`a[href="/${HOST}/edit"]`).first().click();
|
|
await page.waitForURL((u) => u.pathname === `/${HOST}/edit`, { timeout: 15000 });
|
|
expect(await page.evaluate(() => window.__noReload)).toBe(true); // it was a SPA nav, no full reload
|
|
// the picker, brought in by the swap, loaded its first page of candidates
|
|
await expect.poll(() => page.locator(RELROWS).count(), { timeout: 12000 }).toBeGreaterThanOrEqual(1);
|
|
await expect(page.locator(RELR)).toContainText('Picker Item');
|
|
});
|
|
|
|
test('a dropped relate-options fetch shows a visible error/retry state', async ({ page }) => {
|
|
// Simulate the connection dropping for the candidate endpoint. The engine's
|
|
// fetch rejects -> it marks .sx-error on the picker (and keeps retrying), so a
|
|
// stuck/offline picker is VISIBLE instead of an endless silent "Loading…".
|
|
await page.route('**/relate-options*', (route) => route.abort());
|
|
await loginTo(page, `/${HOST}/edit`);
|
|
await waitReady(page);
|
|
// the filter form's "load" fetch fails -> .sx-error lands on the picker form
|
|
await expect(page.locator(`${REL}.sx-error`)).toHaveCount(1, { timeout: 12000 });
|
|
// and recovery: once the endpoint works again, the next retry clears the error
|
|
// and populates (proves the retry loop is live, not a dead end).
|
|
await page.unroute('**/relate-options*');
|
|
await expect(page.locator(`${REL}.sx-error`)).toHaveCount(0, { timeout: 35000 });
|
|
await expect.poll(() => page.locator(RELROWS).count(), { timeout: 12000 }).toBeGreaterThan(0);
|
|
});
|
|
});
|