giles
7bec86289c
Reported: logged in, go to an edit page, then press Home — nothing happens.
Root cause (browser-DOM trace): a boosted nav home→post morphs a home footer <a> into the
post's "edit" link (morph reuses nodes positionally). morph-node's sync-attrs then STRIPS any
attribute the old node has but the SERVER node lacks — which removes the boost's
client-injected sx-swap="innerHTML" (the server never sends it). With sx-swap gone the swap
defaults to outerHTML, so clicking edit REPLACES #content (the <div id=content>) with the edit
fragment's <div> (no id) — DOM trace: "sx-boost children [NAV, DIV#content]" → "[NAV, DIV]".
#content is destroyed, so every later boosted nav (Home) fetches but has no swap target
("post-swap: root=nil") → nothing updates.
Fix: sync-attrs no longer removes the boost's injected navigation attributes (sx-target /
sx-swap / sx-push-url / sx-get / sx-select) when the new (server) node lacks them — they're
identical across all boosted links, so a reused node keeps sx-swap="innerHTML" and the swap
morphs #content's children instead of replacing #content. Recompiled the web stack. Pairs
with a511b21d (fresh href) + 88f8b427 (SX-Redirect) — three facets of the morph-node-reuse
problem (stale href, lost swap attr, guarded-redirect clobber).
TEST-FIRST: added a 3rd boost-nav.spec.js case (LOGGED IN: home→post→edit, assert #content
survives + Home works). Reproduced RED via DOM traces (#content count 0), GREEN after — on the
ephemeral server AND live. No regressions: picker 3/3 + block-editor 1/1.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
52 lines
1.9 KiB
Bash
Executable File
52 lines
1.9 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Regression harness for the boosted-nav link-rebinding bug (composition step polish).
|
|
# Spins up an EPHEMERAL host server (this worktree's binary + lib + web + WASM), which on
|
|
# boot seeds /compose-demo and the home footer's /tags link, runs boost-nav.spec.js in the
|
|
# main worktree's Playwright, then tears down. No live-site dependency.
|
|
#
|
|
# bash lib/host/playwright/run-boost-nav-check.sh
|
|
#
|
|
# Requires: the OCaml binary built + Playwright + chromium in /root/rose-ash.
|
|
set -uo pipefail
|
|
cd "$(git rev-parse --show-toplevel)"
|
|
ROOT=$(pwd)
|
|
|
|
PORT="${BOOST_PORT:-8914}"
|
|
PW_DIR="${PW_DIR:-/root/rose-ash}"
|
|
USER="admin"; PASS="boost-check-pw"; SECRET="boost-check-secret"
|
|
PDIR=$(mktemp -d)
|
|
SPEC_SRC="lib/host/playwright/boost-nav.spec.js"
|
|
SPEC_DST="$PW_DIR/tests/playwright/_boost-nav-check.spec.js"
|
|
SERVE_LOG=$(mktemp)
|
|
|
|
cleanup() {
|
|
[ -n "${SVPID:-}" ] && kill "$SVPID" 2>/dev/null
|
|
local pid
|
|
pid=$(ss -lptn "sport = :$PORT" 2>/dev/null | grep -oE 'pid=[0-9]+' | head -1 | cut -d= -f2)
|
|
[ -n "$pid" ] && kill "$pid" 2>/dev/null
|
|
rm -f "$SPEC_DST" "$SERVE_LOG"; rm -rf "$PDIR"
|
|
}
|
|
trap cleanup EXIT
|
|
|
|
echo "== starting ephemeral host server on :$PORT (persist=$PDIR) =="
|
|
SX_SERVING_JIT=1 HOST_PORT="$PORT" SX_PERSIST_DIR="$PDIR" \
|
|
SX_ADMIN_USER="$USER" SX_ADMIN_PASSWORD="$PASS" SX_SESSION_SECRET="$SECRET" \
|
|
bash lib/host/serve.sh >"$SERVE_LOG" 2>&1 &
|
|
SVPID=$!
|
|
for i in $(seq 1 60); do
|
|
curl -sf -o /dev/null "http://127.0.0.1:$PORT/health" 2>/dev/null && break
|
|
sleep 1
|
|
[ "$i" = "60" ] && { echo "server never came up:"; cat "$SERVE_LOG"; exit 1; }
|
|
done
|
|
echo "== server up =="
|
|
|
|
echo "== running Playwright =="
|
|
cp "$ROOT/$SPEC_SRC" "$SPEC_DST"
|
|
cd "$PW_DIR"
|
|
SX_TEST_URL="http://127.0.0.1:$PORT" SX_ADMIN_USER="$USER" SX_ADMIN_PASSWORD="$PASS" \
|
|
node_modules/.bin/playwright test _boost-nav-check.spec.js --workers=1 \
|
|
--config tests/playwright/playwright.config.js
|
|
RC=$?
|
|
echo "== done (exit $RC) =="
|
|
exit $RC
|