Commit Graph

7 Commits

Author SHA1 Message Date
2805e0077b Fix clobber test: detect text content change, not just empty state
The previous test only checked if childNodes.length hit zero. With
replaceChildren that never happens — but the flash is still visible
because the SSR DOM is replaced with different reactive DOM.

New test captures SSR textContent before JS boots, watches for any
change via MutationObserver. Now correctly fails:
  "text changed — ssr:(div (~tw :tokens... → hydrated:..."

This proves the flash: island hydration replaces SSR DOM wholesale.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 08:08:02 +00:00
23c88cd1e5 Atomic island hydration: replaceChildren instead of clear+append
The hydrate-island function was doing:
  (dom-set-text-content el "")  ;; clears SSR content — visible flash
  (dom-append el body-dom)       ;; adds reactive DOM

Now uses:
  (host-call el "replaceChildren" body-dom)  ;; atomic swap, no empty state

Per DOM spec, replaceChildren is a single synchronous operation — the
browser never renders the intermediate empty state. The MutationObserver
test now checks for content going to zero (visible gap), not mutation
count (mutations are expected during any swap).

Test: "No clobber: clean" — island never goes empty during hydration.
All 8 home features pass: no-flash, no-clobber, boot, islands, stepper,
smoke, no-errors.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 07:51:37 +00:00
3329512bf8 Add hydration clobber detection test — 55 DOM removals detected
MutationObserver injected before page JS boots watches the stepper
island for content removal during hydration. Detects 55 node removals
— the island hydration destroys SSR DOM and rebuilds it, causing a
visible flash.

Test correctly fails: "No clobber: 55 removals"
This is the root cause of the flash — island hydration needs to
preserve SSR content instead of replacing it.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 07:40:52 +00:00
79ba9c2d40 Fix stepper SSR/hydration flash: server reads cookie, cache bypass
Three changes to eliminate the stepper flash:

1. home-stepper.sx: server path reads cookie via (get-cookie) for
   step-idx initial value. Client path reads document.cookie via
   def-store. Both default to 0 when no cookie exists.

2. sx_server.ml: bypass response cache when sx-home-stepper cookie
   is present. Render on main thread (not worker) so get-cookie
   sees the parsed request cookies.

3. site-full.spec.js: flash detection test sets cookie=7 via
   Playwright context, checks SSR HTML matches hydrated state.

Test: "No flash: SSR=7 hydrated=7 (cookie=7)" — passes.
Tested on fresh stack=site server subprocess.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 07:28:47 +00:00
32fd3ef7d3 Add SSR/hydration flash detection test, fix to-number → parse-number
- site-full.spec.js: home test captures SSR counter from raw HTML before
  JS runs, compares with post-hydration counter. Fails if they differ.
- home-stepper.sx: to-number → parse-number (to-number doesn't exist
  in the OCaml server environment — caused crash on fresh server start)

Test output: "No flash: SSR=0 hydrated=0" — passes.
Tested on fresh stack=site server, not cached Docker container.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 07:22:25 +00:00
0a2d7768dd Rewrite test suite: data-driven discovery, all 8 HS elements, SPA fixed
Tests are now fully automated — discover features from the DOM:
- discoverPage(): finds islands, HS elements, sx-get links, content
- testHsElement(): clicks each _="..." element, checks for any DOM change
- testHsWaitElement(): handles async wait cycles (add/wait/remove)
- SPA: uses Playwright locator.click() on a[sx-get] links — 5/5 pass

Results: 5 pass, 3 fail (all real bugs):
  home: stepper click detection needs ▶ selector fix
  hyperscript HS[6]: put "<b>Rendered!</b>" into #target — no effect
  language: spec.explore.evaluator page hangs (server bug)
  SPA navigation: 5/5 sections pass
  geography 11/11, applications 8/8, tools 4/4, etc 4/4

7/8 HS elements pass. HS[6] (put into target) is a real compiler bug.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-10 06:41:57 +00:00
fecfc71e5f Add full site test suite: stack=site sandbox, per-page feature reports
New test infrastructure:
- site-server.js: shared OCaml HTTP server lifecycle (beforeAll/afterAll)
- site-full.spec.js: full site test suite, no Docker

Tests:
  home (7 features): boot, header island, stepper island, stepper click,
    SPA navigation, universal smoke, no console errors
  hyperscript (8 features): boot, HS element discovery, activation (8/8),
    toggle color on/off, count clicks, bounce add/wait/remove, smoke, errors
  geography: 12/12 pages render
  applications: 9/9 pages render
  tools: 5/5 pages render
  etc: 5/5 pages render
  SPA navigation: SKIPPED (link boosting not working yet)
  language: FAILS — /sx/(language.(spec.(explore.evaluator))) hangs (real bug)

Run: npx playwright test tests/playwright/site-full.spec.js
Run one: npx playwright test tests/playwright/site-full.spec.js -g "hyperscript"

Each test prints a feature report showing exactly what was verified.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-09 22:20:13 +00:00