coop/rose-ash
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

Remove debug logging from sx_browser.ml and sx-platform.js

Browse Source 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
giles
2026-04-16 17:08:01 +00:00
parent 1bce1b701b
commit d981e5f620
19 changed files with 1921 additions and 775 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
hosts/ocaml/browser/sx-platform.js
View File

@@ -57,7 +57,6 @@
var obj = args[0], method = args[1];
var callArgs = [];
for (var i = 2; i < args.length; i++) callArgs.push(args[i]);
if (method === "addEventListener") console.log("[host-call] addEventListener args:", callArgs.map(a => typeof a === "function" ? "fn:" + (a.__host_callback ? "HOST_CB" : "other") : typeof a));
if (obj == null) {
// Global function call
var fn = typeof globalThis !== "undefined" ? globalThis[method] : window[method];
@@ -160,9 +159,7 @@
if (fn && fn.__sx_handle !== undefined) {
var wrappedFn = function() {
var a = Array.prototype.slice.call(arguments);
console.log("[host-callback] FIRED handle=" + fn.__sx_handle);
var r = K.callFn(fn, a);
console.log("[host-callback] callFn returned suspended=" + !!(r && r.suspended));
if (window._driveAsync) window._driveAsync(r);
return r;
};

7
hosts/ocaml/browser/sx_browser.ml
View File

@@ -91,9 +91,7 @@ let rec value_to_js (v : value) : Js.Unsafe.any =
| Dict d ->
(* Check for __host_handle — return original JS object *)
(match Hashtbl.find_opt d "__host_handle" with
| Some (Number n) ->
Printf.eprintf "[value_to_js] Dict→host_get_js handle=%d\n%!" (int_of_float n);
host_get_js (int_of_float n)
| Some (Number n) -> host_get_js (int_of_float n)
| _ ->
let obj = Js.Unsafe.obj [||] in
Js.Unsafe.set obj (Js.string "_type") (Js.string "dict");
@@ -171,8 +169,6 @@ and js_to_value (js : Js.Unsafe.any) : value =
| "function" ->
let h = Js.Unsafe.get js (Js.string "__sx_handle") in
let has_host_cb = Js.to_bool (Js.Unsafe.coerce (Js.Unsafe.get js (Js.string "__host_callback"))) in
if has_host_cb then
Printf.eprintf "[js_to_value] fn has __host_callback! Storing as host obj\n%!";
if not (Js.Unsafe.equals h Js.undefined) && not has_host_cb then
get_handle (Js.float_of_number (Js.Unsafe.coerce h) |> int_of_float)
else
@@ -181,7 +177,6 @@ and js_to_value (js : Js.Unsafe.any) : value =
This preserves wrappers like _driveAsync that host-callback
attaches for IO suspension handling. *)
let id = host_put js in
Printf.eprintf "[js_to_value] plain JS fn → host_object id=%d\n%!" id;
let d = Hashtbl.create 2 in
Hashtbl.replace d "__host_handle" (Number (float_of_int id));
Dict d