Fix tag name case in default trigger detection, refactor engine tests

Tag names from dom-tag-name are lowercase (not uppercase) in the WASM
kernel — fix FORM/INPUT/SELECT/TEXTAREA comparisons in get-default-trigger.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

shared/static/wasm/sx/engine.sx

@@ -72,12 +72,12 @@
   (fn
     ((tag-name :as string))
     (cond
-      (= tag-name "FORM")
+      (= tag-name "form")
       (list (dict "event" "submit" "modifiers" (dict)))
       (or
-        (= tag-name "INPUT")
+        (= tag-name "input")
-        (= tag-name "SELECT")
+        (= tag-name "select")
-        (= tag-name "TEXTAREA"))
+        (= tag-name "textarea"))
       (list (dict "event" "change" "modifiers" (dict)))
       :else (list (dict "event" "click" "modifiers" (dict))))))
 

web/engine.sx

@@ -72,12 +72,12 @@
   (fn
     ((tag-name :as string))
     (cond
-      (= tag-name "FORM")
+      (= tag-name "form")
       (list (dict "event" "submit" "modifiers" (dict)))
       (or
-        (= tag-name "INPUT")
+        (= tag-name "input")
-        (= tag-name "SELECT")
+        (= tag-name "select")
-        (= tag-name "TEXTAREA"))
+        (= tag-name "textarea"))
       (list (dict "event" "change" "modifiers" (dict)))
       :else (list (dict "event" "click" "modifiers" (dict))))))
 

web/tests/test-engine.sx

@@ -1,212 +1,182 @@
-;; ==========================================================================
+(defsuite
-;; test-engine.sx — Tests for SxEngine pure logic (engine.sx)
+  "parse-time"
-;;
+  (deftest "seconds to ms" (assert-equal 2000 (parse-time "2s")))
-;; Requires: test-framework.sx loaded first.
+  (deftest "milliseconds" (assert-equal 500 (parse-time "500ms")))
-;; Platform functions: parse-time, parse-trigger-spec, default-trigger,
+  (deftest "nil returns 0" (assert-equal 0 (parse-time nil)))
-;;   parse-swap-spec, parse-retry-spec, next-retry-ms, filter-params
+  (deftest "plain number string" (assert-equal 100 (parse-time "100")))
-;;   (loaded from bootstrapped output by test runners)
+  (deftest "one second" (assert-equal 1000 (parse-time "1s")))
-;; ==========================================================================
+  (deftest "large seconds" (assert-equal 30000 (parse-time "30s"))))
 
-
+(defsuite
-;; --------------------------------------------------------------------------
+  "parse-trigger-spec"
-;; 1. parse-time — time string parsing
+  (deftest "nil returns nil" (assert-nil (parse-trigger-spec nil)))
-;; --------------------------------------------------------------------------
+  (deftest
-
+    "single event"
-(defsuite "parse-time"
+    (let
-
+      ((triggers (parse-trigger-spec "click")))
-  (deftest "seconds to ms"
-    (assert-equal 2000 (parse-time "2s")))
-
-  (deftest "milliseconds"
-    (assert-equal 500 (parse-time "500ms")))
-
-  (deftest "nil returns 0"
-    (assert-equal 0 (parse-time nil)))
-
-  (deftest "plain number string"
-    (assert-equal 100 (parse-time "100")))
-
-  (deftest "one second"
-    (assert-equal 1000 (parse-time "1s")))
-
-  (deftest "large seconds"
-    (assert-equal 30000 (parse-time "30s"))))
-
-
-;; --------------------------------------------------------------------------
-;; 2. parse-trigger-spec — trigger attribute parsing
-;; --------------------------------------------------------------------------
-
-(defsuite "parse-trigger-spec"
-
-  (deftest "nil returns nil"
-    (assert-nil (parse-trigger-spec nil)))
-
-  (deftest "single event"
-    (let ((triggers (parse-trigger-spec "click")))
       (assert-equal 1 (len triggers))
       (assert-equal "click" (get (first triggers) "event"))))
-
+  (deftest
-  (deftest "event with once modifier"
+    "event with once modifier"
-    (let ((triggers (parse-trigger-spec "click once")))
+    (let
+      ((triggers (parse-trigger-spec "click once")))
       (assert-equal 1 (len triggers))
       (assert-equal "click" (get (first triggers) "event"))
       (assert-true (get (get (first triggers) "modifiers") "once"))))
-
+  (deftest
-  (deftest "event with delay modifier"
+    "event with delay modifier"
-    (let ((triggers (parse-trigger-spec "click delay:500ms")))
+    (let
+      ((triggers (parse-trigger-spec "click delay:500ms")))
       (assert-equal 1 (len triggers))
       (assert-equal 500 (get (get (first triggers) "modifiers") "delay"))))
-
+  (deftest
-  (deftest "multiple triggers comma-separated"
+    "multiple triggers comma-separated"
-    (let ((triggers (parse-trigger-spec "click,change")))
+    (let
+      ((triggers (parse-trigger-spec "click,change")))
       (assert-equal 2 (len triggers))
       (assert-equal "click" (get (first triggers) "event"))
       (assert-equal "change" (get (nth triggers 1) "event"))))
-
+  (deftest
-  (deftest "polling trigger"
+    "polling trigger"
-    (let ((triggers (parse-trigger-spec "every 3s")))
+    (let
+      ((triggers (parse-trigger-spec "every 3s")))
       (assert-equal 1 (len triggers))
       (assert-equal "every" (get (first triggers) "event"))
-      (assert-equal 3000 (get (get (first triggers) "modifiers") "interval"))))
+      (assert-equal
-
+        3000
-  (deftest "event with from modifier"
+        (get (get (first triggers) "modifiers") "interval"))))
-    (let ((triggers (parse-trigger-spec "click from:body")))
+  (deftest
+    "event with from modifier"
+    (let
+      ((triggers (parse-trigger-spec "click from:body")))
       (assert-equal "body" (get (get (first triggers) "modifiers") "from"))))
-
+  (deftest
-  (deftest "event with changed modifier"
+    "event with changed modifier"
-    (let ((triggers (parse-trigger-spec "keyup changed")))
+    (let
+      ((triggers (parse-trigger-spec "keyup changed")))
       (assert-equal "keyup" (get (first triggers) "event"))
       (assert-true (get (get (first triggers) "modifiers") "changed")))))
 
-
+(defsuite
-;; --------------------------------------------------------------------------
+  "default-trigger"
-;; 3. default-trigger — default trigger by element tag
+  (deftest
-;; --------------------------------------------------------------------------
+    "form submits"
-
+    (let
-(defsuite "default-trigger"
+      ((triggers (default-trigger "form")))
-
-  (deftest "form submits"
-    (let ((triggers (default-trigger "FORM")))
       (assert-equal "submit" (get (first triggers) "event"))))
-
+  (deftest
-  (deftest "input changes"
+    "input changes"
-    (let ((triggers (default-trigger "INPUT")))
+    (let
+      ((triggers (default-trigger "input")))
       (assert-equal "change" (get (first triggers) "event"))))
-
+  (deftest
-  (deftest "select changes"
+    "select changes"
-    (let ((triggers (default-trigger "SELECT")))
+    (let
+      ((triggers (default-trigger "select")))
       (assert-equal "change" (get (first triggers) "event"))))
-
+  (deftest
-  (deftest "textarea changes"
+    "textarea changes"
-    (let ((triggers (default-trigger "TEXTAREA")))
+    (let
+      ((triggers (default-trigger "textarea")))
       (assert-equal "change" (get (first triggers) "event"))))
-
+  (deftest
-  (deftest "div clicks"
+    "div clicks"
-    (let ((triggers (default-trigger "DIV")))
+    (let
+      ((triggers (default-trigger "div")))
       (assert-equal "click" (get (first triggers) "event"))))
-
+  (deftest
-  (deftest "button clicks"
+    "button clicks"
-    (let ((triggers (default-trigger "BUTTON")))
+    (let
+      ((triggers (default-trigger "button")))
       (assert-equal "click" (get (first triggers) "event")))))
 
-
+(defsuite
-;; --------------------------------------------------------------------------
+  "parse-swap-spec"
-;; 4. parse-swap-spec — swap specification parsing
+  (deftest
-;; --------------------------------------------------------------------------
+    "default swap"
-
+    (let
-(defsuite "parse-swap-spec"
+      ((spec (parse-swap-spec nil false)))
-
-  (deftest "default swap"
-    (let ((spec (parse-swap-spec nil false)))
       (assert-equal "outerHTML" (get spec "style"))
       (assert-false (get spec "transition"))))
-
+  (deftest
-  (deftest "innerHTML"
+    "innerHTML"
-    (let ((spec (parse-swap-spec "innerHTML" false)))
+    (let
+      ((spec (parse-swap-spec "innerHTML" false)))
       (assert-equal "innerHTML" (get spec "style"))))
-
+  (deftest
-  (deftest "with transition true"
+    "with transition true"
-    (let ((spec (parse-swap-spec "innerHTML transition:true" false)))
+    (let
+      ((spec (parse-swap-spec "innerHTML transition:true" false)))
       (assert-equal "innerHTML" (get spec "style"))
       (assert-true (get spec "transition"))))
-
+  (deftest
-  (deftest "transition false overrides global"
+    "transition false overrides global"
-    (let ((spec (parse-swap-spec "outerHTML transition:false" true)))
+    (let
+      ((spec (parse-swap-spec "outerHTML transition:false" true)))
       (assert-equal "outerHTML" (get spec "style"))
       (assert-false (get spec "transition"))))
-
+  (deftest
-  (deftest "global transition when not overridden"
+    "global transition when not overridden"
-    (let ((spec (parse-swap-spec "innerHTML" true)))
+    (let
+      ((spec (parse-swap-spec "innerHTML" true)))
       (assert-equal "innerHTML" (get spec "style"))
       (assert-true (get spec "transition")))))
 
-
+(defsuite
-;; --------------------------------------------------------------------------
+  "parse-retry-spec"
-;; 5. parse-retry-spec — retry specification parsing
+  (deftest "nil returns nil" (assert-nil (parse-retry-spec nil)))
-;; --------------------------------------------------------------------------
+  (deftest
-
+    "exponential backoff"
-(defsuite "parse-retry-spec"
+    (let
-
+      ((spec (parse-retry-spec "exponential:1000:30000")))
-  (deftest "nil returns nil"
-    (assert-nil (parse-retry-spec nil)))
-
-  (deftest "exponential backoff"
-    (let ((spec (parse-retry-spec "exponential:1000:30000")))
       (assert-equal "exponential" (get spec "strategy"))
       (assert-equal 1000 (get spec "start-ms"))
       (assert-equal 30000 (get spec "cap-ms"))))
-
+  (deftest
-  (deftest "linear strategy"
+    "linear strategy"
-    (let ((spec (parse-retry-spec "linear:2000:60000")))
+    (let
+      ((spec (parse-retry-spec "linear:2000:60000")))
       (assert-equal "linear" (get spec "strategy"))
       (assert-equal 2000 (get spec "start-ms"))
       (assert-equal 60000 (get spec "cap-ms")))))
 
-
+(defsuite
-;; --------------------------------------------------------------------------
+  "next-retry-ms"
-;; 6. next-retry-ms — exponential backoff calculation
+  (deftest "doubles current" (assert-equal 2000 (next-retry-ms 1000 30000)))
-;; --------------------------------------------------------------------------
+  (deftest
-
+    "caps at maximum"
-(defsuite "next-retry-ms"
-
-  (deftest "doubles current"
-    (assert-equal 2000 (next-retry-ms 1000 30000)))
-
-  (deftest "caps at maximum"
     (assert-equal 30000 (next-retry-ms 20000 30000)))
+  (deftest "exact cap" (assert-equal 30000 (next-retry-ms 15000 30000)))
+  (deftest "small initial" (assert-equal 200 (next-retry-ms 100 30000))))
 
-  (deftest "exact cap"
+(defsuite
-    (assert-equal 30000 (next-retry-ms 15000 30000)))
+  "filter-params"
-
+  (deftest
-  (deftest "small initial"
+    "nil passes all through"
-    (assert-equal 200 (next-retry-ms 100 30000))))
+    (let
-
+      ((params (list (list "a" "1") (list "b" "2"))))
-
-;; --------------------------------------------------------------------------
-;; 7. filter-params — form parameter filtering
-;; --------------------------------------------------------------------------
-
-(defsuite "filter-params"
-
-  (deftest "nil passes all through"
-    (let ((params (list (list "a" "1") (list "b" "2"))))
       (assert-equal 2 (len (filter-params nil params)))))
-
+  (deftest
-  (deftest "none returns empty"
+    "none returns empty"
-    (let ((params (list (list "a" "1") (list "b" "2"))))
+    (let
+      ((params (list (list "a" "1") (list "b" "2"))))
       (assert-equal 0 (len (filter-params "none" params)))))
-
+  (deftest
-  (deftest "star passes all"
+    "star passes all"
-    (let ((params (list (list "a" "1") (list "b" "2"))))
+    (let
+      ((params (list (list "a" "1") (list "b" "2"))))
       (assert-equal 2 (len (filter-params "*" params)))))
-
+  (deftest
-  (deftest "whitelist"
+    "whitelist"
-    (let ((params (list (list "name" "Jo") (list "age" "30") (list "secret" "x"))))
+    (let
-      (let ((filtered (filter-params "name,age" params)))
+      ((params (list (list "name" "Jo") (list "age" "30") (list "secret" "x"))))
+      (let
+        ((filtered (filter-params "name,age" params)))
         (assert-equal 2 (len filtered)))))
-
+  (deftest
-  (deftest "blacklist with not"
+    "blacklist with not"
-    (let ((params (list (list "name" "Jo") (list "csrf" "tok") (list "age" "30"))))
+    (let
-      (let ((filtered (filter-params "not csrf" params)))
+      ((params (list (list "name" "Jo") (list "csrf" "tok") (list "age" "30"))))
+      (let
+        ((filtered (filter-params "not csrf" params)))
         (assert-equal 2 (len filtered))))))