coop/rose-ash
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HS-gen: string-aware line-comment stripping (+1 test)

Browse Source 
process_hs_val stripped `//…` line comments with a naïve regex,
which devoured `https://yyy.xxxxxx.com/…` inside a backtick template
— the 'properly interpolates values 2' fixture was landing with
the HS source truncated at `https:`.

New helper _strip_hs_line_comments walks char-by-char and only
strips `//` / leading-whitespace `--` when not inside `'…'`, `"…"`,
or backticks; respects `\\`-escapes inside strings.

Suite hs-upstream-core/regressions: 11/16 → 12/16.
Smoke 0-195: 163/195 → 164/195.
This commit is contained in:
giles
2026-04-24 09:42:19 +00:00
parent 094945d86a
commit cb37259d10
4 changed files with 51 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plans/hs-conformance-scoreboard.md
View File

@@ -4,10 +4,10 @@ Live tally for `plans/hs-conformance-to-100.md`. Update after every cluster comm
```
Baseline: 1213/1496 (81.1%)
Merged: 1248/1496 (83.4%) delta +35
Merged: 1249/1496 (83.5%) delta +36
Worktree: all merged
Target: 1496/1496 (100.0%)
Remaining: ~248 tests
Remaining: ~247 tests
```
## Cluster ledger
@@ -44,7 +44,7 @@ Remaining: ~248 tests
| 21 | `possessiveExpression` property access via its | done | +1 | f0c41278 |
| 22 | window global fn fallback | blocked | — | — |
| 23 | `me symbol works in from expressions` | done | +1 | 0d38a75b |
| 24 | `properly interpolates values 2` | pending | (+1 est) | — |
| 24 | `properly interpolates values 2` | done | +1 | (pending) |
| 25 | parenthesized commands and features | pending | (+1 est) | — |
### Bucket C — feature stubs (observer mocks)
@@ -86,7 +86,7 @@ Defer until A–D drain. Estimated ~25 recoverable tests.
| Bucket | Done | Partial | In-prog | Pending | Blocked | Design-done | Total |
|--------|-----:|--------:|--------:|--------:|--------:|------------:|------:|
| A | 12 | 4 | 0 | 0 | 1 | — | 17 |
| B | 2 | 0 | 0 | 4 | 1 | — | 7 |
| B | 3 | 0 | 0 | 3 | 1 | — | 7 |
| C | 0 | 0 | 0 | 5 | 0 | — | 5 |
| D | 0 | 0 | 0 | 5 | 0 | — | 5 |
| E | 0 | 0 | 0 | 0 | 0 | 5 | 5 |