coop/rose-ash
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hydrate-island: clear-and-replace instead of hydration walk

Browse Source 
Islands now clear SSR children before render-to-dom and append the
fresh DOM result. Avoids hydrate-mismatch errors from SSR/client
attribute differences (~tw generates different class strings).

The hydrating scope is set to nil (no cursor walk) so render-to-dom
creates new DOM nodes instead of trying to reuse SSR elements.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
giles
2026-04-16 13:35:45 +00:00
parent c9634ba649
commit ca077b429b
2 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
shared/static/wasm/sx/boot.sx
View File

@@ -332,20 +332,25 @@
(component-params comp)) (component-params comp))
(let (let
((cursor (dict "parent" el "index" 0))) ((cursor (dict "parent" el "index" 0)))
(scope-push! "sx-hydrating" cursor) (host-call el "replaceChildren")
(scope-push! "sx-hydrating" nil)
(cek-try (cek-try
(fn (fn
() ()
(with-island-scope (with-island-scope
(fn (disposable) (append! disposers disposable)) (fn (disposable) (append! disposers disposable))
(fn () (render-to-dom (component-body comp) local nil)))) (fn
()
(let
((result (render-to-dom (component-body comp) local el)))
(when result (dom-append el result))))))
(fn (fn
(err) (err)
(scope-pop! "sx-hydrating") (scope-pop! "sx-hydrating")
(log-warn (log-warn
(str "hydrate fallback: " comp-name " — " err)) (str "hydrate fallback: " comp-name " — " err))
(let (let
((fallback (cek-try (fn () (with-island-scope (fn (d) (append! disposers d)) (fn () (render-to-dom (component-body comp) local nil)))) (fn (err2) (let ((e (dom-create-element "div" nil))) (dom-set-text-content e (str "Island error: " comp-name "\n" err2)) e))))) ((fallback (dom-create-text (str "Island error: " comp-name " " err))))
(host-call el "replaceChildren" fallback) (host-call el "replaceChildren" fallback)
nil))) nil)))
(scope-pop! "sx-hydrating") (scope-pop! "sx-hydrating")

11
web/boot.sx
View File

@@ -332,20 +332,25 @@
(component-params comp)) (component-params comp))
(let (let
((cursor (dict "parent" el "index" 0))) ((cursor (dict "parent" el "index" 0)))
(scope-push! "sx-hydrating" cursor) (host-call el "replaceChildren")
(scope-push! "sx-hydrating" nil)
(cek-try (cek-try
(fn (fn
() ()
(with-island-scope (with-island-scope
(fn (disposable) (append! disposers disposable)) (fn (disposable) (append! disposers disposable))
(fn () (render-to-dom (component-body comp) local nil)))) (fn
()
(let
((result (render-to-dom (component-body comp) local el)))
(when result (dom-append el result))))))
(fn (fn
(err) (err)
(scope-pop! "sx-hydrating") (scope-pop! "sx-hydrating")
(log-warn (log-warn
(str "hydrate fallback: " comp-name " — " err)) (str "hydrate fallback: " comp-name " — " err))
(let (let
((fallback (cek-try (fn () (with-island-scope (fn (d) (append! disposers d)) (fn () (render-to-dom (component-body comp) local nil)))) (fn (err2) (let ((e (dom-create-element "div" nil))) (dom-set-text-content e (str "Island error: " comp-name "\n" err2)) e))))) ((fallback (dom-create-text (str "Island error: " comp-name " " err))))
(host-call el "replaceChildren" fallback) (host-call el "replaceChildren" fallback)
nil))) nil)))
(scope-pop! "sx-hydrating") (scope-pop! "sx-hydrating")