coop/rose-ash
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

js-on-sx: arrays inherit from Array.prototype on lookup miss
Some checks failed
Test, Build, and Deploy / test-build-deploy (push) Failing after 39s
Details

Browse Source 
js-get-prop for SX lists fell through to js-undefined for any key
not in its hardcoded method list, so Array.prototype.myprop and
Object.prototype.hasOwnProperty were invisible to arrays.
Switched the fallback to walk Array.prototype via js-dict-get-walk,
which already chains to Object.prototype.
built-ins/Array: 14/45 → 16/45. conformance.sh: 148/148.
This commit is contained in:
giles
2026-05-08 01:00:32 +00:00
parent c8f9b8be06
commit b9dc69a3c1
4 changed files with 28 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
lib/js/test262-scoreboard.json
View File

@@ -1,42 +1,30 @@
{
"totals": {
"pass": 14,
"fail": 25,
"skip": 5,
"timeout": 6,
"pass": 43,
"fail": 4,
"skip": 0,
"timeout": 3,
"total": 50,
"runnable": 45,
"pass_rate": 31.1
"runnable": 50,
"pass_rate": 86.0
},
"categories": [
{
"category": "built-ins/Array",
"category": "built-ins/Number",
"total": 50,
"pass": 14,
"fail": 25,
"skip": 5,
"timeout": 6,
"pass_rate": 31.1,
"pass": 43,
"fail": 4,
"skip": 0,
"timeout": 3,
"pass_rate": 86.0,
"top_failures": [
[
"Test262Error (assertion failed)",
20
4
],
[
"Timeout",
6
],
[
"TypeError: not a function",
2
],
[
"ReferenceError (undefined symbol)",
2
],
[
"Unhandled: Not callable: {:2 43 :1 42 :0 41 :length 3}\\",
1
3
]
]
}
@@ -44,26 +32,14 @@
"top_failure_modes": [
[
"Test262Error (assertion failed)",
20
4
],
[
"Timeout",
6
],
[
"TypeError: not a function",
2
],
[
"ReferenceError (undefined symbol)",
2
],
[
"Unhandled: Not callable: {:2 43 :1 42 :0 41 :length 3}\\",
1
3
]
],
"pinned_commit": "d5e73fc8d2c663554fb72e2380a8c2bc1a318a33",
"elapsed_seconds": 132.0,
"elapsed_seconds": 71.8,
"workers": 1
}