Fix hydration: effect was a no-op primitive, bytecode compiler emitted CALL_PRIM

Browse Source

Root cause: sx_primitives.ml registered "effect" as a native no-op (for SSR).
The bytecode compiler's (primitive? "effect") returned true, so it emitted
OP_CALL_PRIM instead of OP_GLOBAL_GET + OP_CALL. The VM's CALL_PRIM handler
found the native Nil-returning stub and never called the real effect function
from core-signals.sx.

Fix: Remove effect and register-in-scope from the primitives table. The server
overrides them via env_bind in sx_server.ml (after compilation), which doesn't
affect primitive? checks.

Also: VM CALL_PRIM now falls back to cek_call for non-NativeFn values (safety
net for any other functions that get misclassified).

15/15 source mode, 15/15 bytecode mode.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

...

This commit is contained in:

giles

2026-03-31 16:56:31 +00:00

parent 4cb4551753

commit a7efcaf679

28 changed files with 232 additions and 199 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

BIN

shared/static/wasm/sx_browser.bc.wasm.assets/dune__exe__Sx_browser-87cfa374.wasm → shared/static/wasm/sx_browser.bc.wasm.assets/dune__exe__Sx_browser-8ae21d0a.wasm

Binary file not shown.

2

shared/static/wasm/sx_browser.bc.wasm.assets/dune__exe__Sx_browser-87cfa374.wasm.map → shared/static/wasm/sx_browser.bc.wasm.assets/dune__exe__Sx_browser-8ae21d0a.wasm.map

File diff suppressed because one or more lines are too long

BIN

shared/static/wasm/sx_browser.bc.wasm.assets/dune__exe__Sx_browser-c7939ea0.wasm

Binary file not shown.

1

shared/static/wasm/sx_browser.bc.wasm.assets/dune__exe__Sx_browser-c7939ea0.wasm.map

File diff suppressed because one or more lines are too long

BIN

shared/static/wasm/sx_browser.bc.wasm.assets/start-29cf9a72.wasm

Binary file not shown.

BIN

shared/static/wasm/sx_browser.bc.wasm.assets/start-9e868ccd.wasm

Binary file not shown.

BIN

shared/static/wasm/sx_browser.bc.wasm.assets/sx-0f97ea07.wasm

Binary file not shown.

1

shared/static/wasm/sx_browser.bc.wasm.assets/sx-0f97ea07.wasm.map

File diff suppressed because one or more lines are too long

BIN

shared/static/wasm/sx_browser.bc.wasm.assets/sx-6003da22.wasm

Binary file not shown.

1

shared/static/wasm/sx_browser.bc.wasm.assets/sx-6003da22.wasm.map

File diff suppressed because one or more lines are too long

BIN

shared/static/wasm/sx_browser.bc.wasm.assets/sx-a0c22109.wasm → shared/static/wasm/sx_browser.bc.wasm.assets/sx-86ee6606.wasm

Binary file not shown.

1

shared/static/wasm/sx_browser.bc.wasm.assets/sx-86ee6606.wasm.map Normal file

File diff suppressed because one or more lines are too long

1

shared/static/wasm/sx_browser.bc.wasm.assets/sx-a0c22109.wasm.map

File diff suppressed because one or more lines are too long

BIN

shared/static/wasm/sx_browser.bc.wasm.assets/sx-eb076217.wasm

Binary file not shown.

1

shared/static/wasm/sx_browser.bc.wasm.assets/sx-eb076217.wasm.map

File diff suppressed because one or more lines are too long