fed-sx-m1: Step 6a — pipeline:run_stages driver + validate_inbound/outbound + 10 tests

next/kernel/pipeline.erl

@@ -0,0 +1,37 @@
+-module(pipeline).
+-export([run_stages/2,
+         validate_inbound/1, validate_outbound/1,
+         inbound_stages/0, outbound_stages/0]).
+
+%% Validation pipeline per design §14.
+%%
+%% A stage is a 1-arity fun `(Activity) -> ok | {error, Reason}`.
+%% The driver folds the activity through the stage list, halting
+%% on the first error. The pure-functional driver itself takes a
+%% stage list directly so tests can inject ad-hoc stage sequences
+%% without depending on the bundled inbound/outbound lists.
+%%
+%% Inbound pipeline (full set per design §14): envelope, signature,
+%% replay, audience, activity_schema, object_schema, content_validators,
+%% capabilities, trust. Outbound is a subset (no replay, no trust;
+%% auth handled at the HTTP layer).
+%%
+%% This sub-deliverable (6a) wires only the driver and the empty
+%% stage lists. Concrete stages land in 6b-6c.
+
+run_stages(_Activity, []) -> ok;
+run_stages(Activity, [Stage | Rest]) ->
+    Result = Stage(Activity),
+    case Result of
+        ok         -> run_stages(Activity, Rest);
+        {error, _} -> Result
+    end.
+
+validate_inbound(Activity) ->
+    run_stages(Activity, inbound_stages()).
+
+validate_outbound(Activity) ->
+    run_stages(Activity, outbound_stages()).
+
+inbound_stages()  -> [].
+outbound_stages() -> [].

next/tests/pipeline_driver.sh

@@ -0,0 +1,110 @@
+#!/usr/bin/env bash
+# next/tests/pipeline_driver.sh — Step 6a acceptance test.
+#
+# Exercises the pipeline driver: pipeline:run_stages/2,
+# validate_inbound/1, validate_outbound/1, inbound_stages/0,
+# outbound_stages/0. Concrete stages land in 6b+. 10 cases.
+
+set -uo pipefail
+cd "$(git rev-parse --show-toplevel)"
+
+SX_SERVER="${SX_SERVER:-hosts/ocaml/_build/default/bin/sx_server.exe}"
+if [ ! -x "$SX_SERVER" ]; then
+  SX_SERVER="/root/rose-ash/hosts/ocaml/_build/default/bin/sx_server.exe"
+fi
+if [ ! -x "$SX_SERVER" ]; then
+  echo "ERROR: sx_server.exe not found." >&2
+  exit 1
+fi
+
+VERBOSE="${1:-}"
+PASS=0; FAIL=0; ERRORS=""
+TMPFILE=$(mktemp); trap "rm -f $TMPFILE" EXIT
+
+cat > "$TMPFILE" <<'EPOCHS'
+(epoch 1)
+(load "lib/erlang/tokenizer.sx")
+(load "lib/erlang/parser.sx")
+(load "lib/erlang/parser-core.sx")
+(load "lib/erlang/parser-expr.sx")
+(load "lib/erlang/parser-module.sx")
+(load "lib/erlang/transpile.sx")
+(load "lib/erlang/runtime.sx")
+(load "lib/erlang/vm/dispatcher.sx")
+
+(epoch 2)
+(eval "(get (erlang-load-module (file-read \"next/kernel/pipeline.erl\")) :name)")
+
+;; Empty stage list returns ok
+(epoch 10)
+(eval "(get (erlang-eval-ast \"pipeline:run_stages(anything, []) =:= ok\") :name)")
+
+;; All-ok stages return ok
+(epoch 11)
+(eval "(get (erlang-eval-ast \"pipeline:run_stages(anything, [fun (_) -> ok end, fun (_) -> ok end, fun (_) -> ok end]) =:= ok\") :name)")
+
+;; First failing stage halts; later stages do not run
+(epoch 12)
+(eval "(get (erlang-eval-ast \"pipeline:run_stages(anything, [fun (_) -> ok end, fun (_) -> {error, halt_here} end, fun (_) -> {error, after_halt} end]) =:= {error, halt_here}\") :name)")
+
+;; Single failing stage returns its error
+(epoch 13)
+(eval "(get (erlang-eval-ast \"pipeline:run_stages(anything, [fun (_) -> {error, bad} end]) =:= {error, bad}\") :name)")
+
+;; Stage receives the activity verbatim
+(epoch 14)
+(eval "(get (erlang-eval-ast \"pipeline:run_stages(my_act, [fun (A) -> case A of my_act -> ok; _ -> {error, wrong_arg} end end]) =:= ok\") :name)")
+
+;; Empty inbound_stages / outbound_stages lists
+(epoch 15)
+(eval "(get (erlang-eval-ast \"pipeline:inbound_stages() =:= []\") :name)")
+(epoch 16)
+(eval "(get (erlang-eval-ast \"pipeline:outbound_stages() =:= []\") :name)")
+
+;; Wrappers delegate to run_stages with the right list (empty => ok)
+(epoch 17)
+(eval "(get (erlang-eval-ast \"pipeline:validate_inbound(anything) =:= ok\") :name)")
+(epoch 18)
+(eval "(get (erlang-eval-ast \"pipeline:validate_outbound(anything) =:= ok\") :name)")
+EPOCHS
+
+OUTPUT=$(timeout 120 "$SX_SERVER" < "$TMPFILE" 2>/dev/null)
+
+check() {
+  local epoch="$1" desc="$2" expected="$3"
+  local actual
+  actual=$(echo "$OUTPUT" | awk -v e="$epoch" '
+    $0 ~ "^\\(ok-len " e " " { getline; print; exit }
+    $0 ~ "^\\(ok " e " "     { print; exit }
+    $0 ~ "^\\(error " e " "  { print; exit }
+  ')
+  [ -z "$actual" ] && actual="<no output for epoch $epoch>"
+  if echo "$actual" | grep -qF -- "$expected"; then
+    PASS=$((PASS+1))
+    [ "$VERBOSE" = "-v" ] && echo "  ok $desc"
+  else
+    FAIL=$((FAIL+1))
+    ERRORS+="  FAIL [$desc] (epoch $epoch) expected: $expected | actual: $actual
+"
+  fi
+}
+
+check  2  "module load name"                "pipeline"
+check 10  "empty stage list -> ok"          "true"
+check 11  "all-ok stages -> ok"             "true"
+check 12  "first failure halts pipeline"    "true"
+check 13  "single failing stage"            "true"
+check 14  "stage receives activity verbatim" "true"
+check 15  "inbound_stages = []"             "true"
+check 16  "outbound_stages = []"            "true"
+check 17  "validate_inbound = ok (empty)"   "true"
+check 18  "validate_outbound = ok (empty)"  "true"
+
+TOTAL=$((PASS+FAIL))
+if [ $FAIL -eq 0 ]; then
+  echo "ok $PASS/$TOTAL next/tests/pipeline_driver.sh passed"
+else
+  echo "FAIL $PASS/$TOTAL passed, $FAIL failed:"
+  echo "$ERRORS"
+fi
+[ $FAIL -eq 0 ]