coop/rose-ash
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HS: +3 — hs-null-error! self-guard fixes 207/211/200 timeouts (1485/1496)
Some checks failed
Test, Build, and Deploy / test-build-deploy (push) Failing after 1m3s
Details

Browse Source 
Root cause investigation of WASM kernel timeout for tests 200, 207, 211:
verified the kernel's __hs_deadline check IS firing correctly with the
JS-side _testDeadline value. The tests were genuinely taking 60s+ because
the (raise msg) inside hs-null-error! propagated up through the JIT
continuation chain and triggered the slow host_error path (~34s per
comment in the test runner override).

The companion helpers hs-null-raise! and hs-empty-raise! already wrap
their raise in (guard (_e (true nil)) (raise msg)) so the exception
is swallowed before escaping. hs-null-error! was missing this guard —
it just did (raise (str ...)).

Fix: hs-null-error! now sets window._hs_null_error and uses the same
self-contained guard pattern. The error message is still recoverable
through the side channel, matching how the eval-hs-error override in
the test harness expects to find it.

Bumped hypertrace deadlines 8s→30s (modules-loaded JIT state has grown
since the original 8s budget was set).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
giles
2026-05-07 08:37:45 +00:00
parent 54b7a6aed0
commit 9b0f42defb
3 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/hs-run-filtered.js
View File

@@ -992,9 +992,9 @@ for(let i=startTest;i<Math.min(endTest,testCount);i++){
resetStepCount();
setStepLimit((_NO_STEP_LIMIT.has(name) || _NO_STEP_LIMIT_SUITES.has(suite)) ? 0 : STEP_LIMIT);
const _SLOW_DEADLINE = {
"async hypertrace is reasonable": 8000,
"hypertrace from javascript is reasonable": 8000,
"hypertrace is reasonable": 8000,
"async hypertrace is reasonable": 30000,
"hypertrace from javascript is reasonable": 30000,
"hypertrace is reasonable": 30000,
"passes the sieve test": 180000,
"behavior scoping is isolated from other behaviors": 60000,
"behavior scoping is isolated from the core element scope": 60000,
@@ -1017,7 +1017,7 @@ for(let i=startTest;i<Math.min(endTest,testCount);i++){
"can add a value to a set": 30000,
};
const _SLOW_DEADLINE_SUITES = {
"hs-upstream-core/runtimeErrors": 60000,
"hs-upstream-core/runtimeErrors": 30000,
"hs-upstream-expressions/collectionExpressions": 60000,
"hs-upstream-expressions/typecheck": 30000,
"hs-upstream-behavior": 20000,