coop/rose-ash
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HS: fix null→nil in behavioral tests + globalFunction mock

Browse Source 
SX uses nil (not null) as the null value; null is an undefined symbol
that caused _run-test-thunk to throw before the guard could catch it.
Also adds globalFunction mock for call-cluster tests.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
giles
2026-04-26 21:01:46 +00:00
parent 21c4a7fd5e
commit 8b972483ae
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/tests/test-hyperscript-behavioral.sx
View File

@@ -1172,7 +1172,7 @@
)) ))
(deftest "can call global javascript functions" (deftest "can call global javascript functions"
(hs-cleanup!) (hs-cleanup!)
(host-set! (host-global "window") "calledWith" null) (host-set! (host-global "window") "calledWith" nil)
(let ((_el-div (dom-create-element "div"))) (let ((_el-div (dom-create-element "div")))
(dom-set-attr _el-div "_" "on click call globalFunction(\"foo\")") (dom-set-attr _el-div "_" "on click call globalFunction(\"foo\")")
(dom-append (dom-body) _el-div) (dom-append (dom-body) _el-div)
@@ -1246,7 +1246,7 @@
(defsuite "hs-upstream-core/bootstrap" (defsuite "hs-upstream-core/bootstrap"
(deftest "can call functions" (deftest "can call functions"
(hs-cleanup!) (hs-cleanup!)
(host-set! (host-global "window") "calledWith" null) (host-set! (host-global "window") "calledWith" nil)
(let ((_el-div (dom-create-element "div"))) (let ((_el-div (dom-create-element "div")))
(dom-set-attr _el-div "_" "on click call globalFunction(\"foo\")") (dom-set-attr _el-div "_" "on click call globalFunction(\"foo\")")
(dom-append (dom-body) _el-div) (dom-append (dom-body) _el-div)

3
tests/hs-run-filtered.js
View File

@@ -396,6 +396,9 @@ globalThis.prompt = function(_msg){
globalThis.Event=Ev; globalThis.CustomEvent=Ev; globalThis.NodeList=Array; globalThis.HTMLCollection=Array; globalThis.Event=Ev; globalThis.CustomEvent=Ev; globalThis.NodeList=Array; globalThis.HTMLCollection=Array;
globalThis.getComputedStyle=(e)=>e?e.style:{}; globalThis.requestAnimationFrame=(f)=>{f();return 0;}; globalThis.getComputedStyle=(e)=>e?e.style:{}; globalThis.requestAnimationFrame=(f)=>{f();return 0;};
globalThis.cancelAnimationFrame=()=>{}; globalThis.cancelAnimationFrame=()=>{};
// cluster-36b: globalFunction mock for "can call functions" test.
// The test calls globalFunction("foo") via hyperscript and checks window.calledWith.
globalThis.globalFunction = function(x) { globalThis.calledWith = x; };
// HsMutationObserver — cluster-32 mutation mock. Maintains a global // HsMutationObserver — cluster-32 mutation mock. Maintains a global
// registry; setAttribute/appendChild/removeChild/_setInnerHTML hooks below // registry; setAttribute/appendChild/removeChild/_setInnerHTML hooks below
// fire matching observers synchronously. A re-entry guard // fire matching observers synchronously. A re-entry guard