js-on-sx: delete obj.key actually removes the key
Some checks failed
Test, Build, and Deploy / test-build-deploy (push) Failing after 28s
Some checks failed
Test, Build, and Deploy / test-build-deploy (push) Failing after 28s
js-delete-prop was setting value to js-undefined instead of removing the key, so 'key' in obj remained true and proto-chain lookup didn't fall through. Switched to dict-delete!. Now delete Boolean.prototype.toString; Boolean.prototype.toString() walks up to Object.prototype.toString and returns "[object Boolean]". built-ins/Boolean: 21/27 → 22/27. conformance.sh: 148/148.
This commit is contained in:
@@ -3517,7 +3517,7 @@
|
||||
(obj key)
|
||||
(cond
|
||||
((dict? obj)
|
||||
(begin (dict-set! obj (js-to-string key) js-undefined) true))
|
||||
(begin (dict-delete! obj (js-to-string key)) true))
|
||||
(else true))))
|
||||
|
||||
(define
|
||||
|
||||
Reference in New Issue
Block a user