coop/rose-ash
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

erlang: fix er-env-derived-from? to use identical? not = (cyclic-env hang on structural-= evaluators)

Browse Source
This commit is contained in:
giles
2026-05-18 17:33:48 +00:00
parent b073a82b33
commit 857fae1331
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/erlang/transpile.sx
View File

@@ -1895,15 +1895,20 @@
(define er-env-derived-from? (define er-env-derived-from?
(fn (env target-env) (fn (env target-env)
;; Object-identity check, NOT value `=`. On evaluators where dict `=`
;; is structural/deep, comparing closure envs (which are large and
;; cyclic — a module fun's env references the fun) does not terminate.
;; `identical?` is pointer identity on every host and is the actual
;; intended semantics: "is this the same env object".
(cond (cond
(= env target-env) true (identical? env target-env) true
:else :else
(let ((ks (keys env)) (found-ref (list false))) (let ((ks (keys env)) (found-ref (list false)))
(for-each (for-each
(fn (i) (fn (i)
(when (not (nth found-ref 0)) (when (not (nth found-ref 0))
(let ((v (get env (nth ks i)))) (let ((v (get env (nth ks i))))
(when (and (er-fun? v) (= (get v :env) target-env)) (when (and (er-fun? v) (identical? (get v :env) target-env))
(set-nth! found-ref 0 true))))) (set-nth! found-ref 0 true)))))
(range 0 (len ks))) (range 0 (len ks)))
(nth found-ref 0))))) (nth found-ref 0)))))