coop/rose-ash
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HS: clear _hs_null_error at test boundary — fix bootstrap/can wait (+1 test)
Some checks failed
Test, Build, and Deploy / test-build-deploy (push) Failing after 31s
Details

Browse Source 
hs-win-call sets window._hs_null_error as a side channel when a global
function lookup fails. _driveAsync checks this flag and bails early to
avoid error cascades, but the flag was never cleared between tests.

A previous test (call/can call functions w/ underscores) triggers
hs-win-call when global_function is not set up, which leaves
_hs_null_error="'global_function' is null". The bootstrap/can wait test
then calls `wait 20ms` whose io-sleep resume is skipped by _driveAsync,
so .bar is never added and the assertion fails.

Fix: clear _hs_null_error in the per-test reset block in the test runner.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
giles
2026-05-05 18:49:04 +00:00
parent bf9d342c6e
commit 7acbea01ae
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/hs-run-filtered.js
View File

@@ -809,6 +809,7 @@ for(let i=startTest;i<Math.min(endTest,testCount);i++){
// Reset body // Reset body
_body.children=[];_body.childNodes=[];_body.innerHTML='';_body.textContent=''; _body.children=[];_body.childNodes=[];_body.innerHTML='';_body.textContent='';
globalThis._hs_null_error=null;
globalThis.__test_selection=''; globalThis.__test_selection='';
globalThis.__hsCookieStore.clear(); globalThis.__hsCookieStore.clear();
globalThis.__hsMutationRegistry.length = 0; globalThis.__hsMutationRegistry.length = 0;