datalog: indexed dl-find-bindings + chain-15 differential (Phase 5c, 153/153)
Some checks failed
Test, Build, and Deploy / test-build-deploy (push) Failing after 59s

dl-find-bindings now uses dl-fb-aux lits db subst i n (indexed
iteration via nth) instead of recursive (rest lits). Eliminates
O(N²) list-copy per body of length N. chain-15 saturation 25s
→ 16s; chain-25 finishes in 33s real (vs. timeout previously).

Bumped semi_naive tests to chain-10 differential + chain-15
semi-only count (was chain-5/chain-5). Blocker entry refreshed.
This commit is contained in:
2026-05-08 08:50:24 +00:00
parent de302fc236
commit 790c17dfc1
4 changed files with 32 additions and 20 deletions

View File

@@ -83,14 +83,18 @@
(define (define
dl-find-bindings dl-find-bindings
(fn (lits db subst) (dl-fb-aux lits db subst 0 (len lits))))
(define
dl-fb-aux
(fn (fn
(lits db subst) (lits db subst i n)
(cond (cond
((nil? subst) (list)) ((nil? subst) (list))
((= (len lits) 0) (list subst)) ((>= i n) (list subst))
(else (else
(let (let
((options (dl-match-lit (first lits) db subst)) ((options (dl-match-lit (nth lits i) db subst))
(results (list))) (results (list)))
(do (do
(for-each (for-each
@@ -98,7 +102,7 @@
(s) (s)
(for-each (for-each
(fn (s2) (append! results s2)) (fn (s2) (append! results s2))
(dl-find-bindings (rest lits) db s))) (dl-fb-aux lits db s (+ i 1) n)))
options) options)
results)))))) results))))))

View File

@@ -15,5 +15,5 @@
{"name":"api","passed":9,"failed":0,"total":9}, {"name":"api","passed":9,"failed":0,"total":9},
{"name":"demo","passed":10,"failed":0,"total":10} {"name":"demo","passed":10,"failed":0,"total":10}
], ],
"generated": "2026-05-08T08:45:37+00:00" "generated": "2026-05-08T08:49:52+00:00"
} }

View File

@@ -120,18 +120,18 @@
(dl-sn-counts-agree? (dl-sn-counts-agree?
(dl-sn-counts "p(a). p(b). q(X) :- p(X), =(X, a).")) (dl-sn-counts "p(a). p(b). q(X) :- p(X), =(X, a)."))
true) true)
;; Chain length 5 — small but enough to exercise multiple ;; Chain length 10 — exercises multiple semi-naive iterations
;; semi-naive iterations against a recursive rule. ;; against the recursive ancestor rule.
(dl-sn-test! (dl-sn-test!
"chain-5 ancestor counts match" "chain-10 ancestor counts match"
(dl-sn-counts-agree? (dl-sn-counts (dl-sn-chain-source 5))) (dl-sn-counts-agree? (dl-sn-counts (dl-sn-chain-source 10)))
true) true)
(dl-sn-test! (dl-sn-test!
"chain-5 ancestor count value" "chain-15 ancestor count value (semi only)"
(let (let
((db (dl-program (dl-sn-chain-source 5)))) ((db (dl-program (dl-sn-chain-source 15))))
(do (dl-saturate! db) (len (dl-relation db "ancestor")))) (do (dl-saturate! db) (len (dl-relation db "ancestor"))))
15) 120)
(dl-sn-test! (dl-sn-test!
"query through semi saturate" "query through semi saturate"
(let (let

View File

@@ -256,19 +256,27 @@ large graphs.
## Blockers ## Blockers
- **Saturation perf on long chains.** Resolved one bottleneck (hash-set - **Saturation perf** improving but not free. Resolved hash-set
membership in `dl-add-fact!`) but `dl-saturate!` still spends membership in `dl-add-fact!` and replaced recursive `(rest lits)` in
significant time per iteration on rule body joins — chain-15 takes `dl-find-bindings` with indexed iteration. chain-15 drops from ~25s
~25s real / 3s user under contention even after the membership fix. to ~16s and chain-25 saturates in ~33s real / 11s user — most CPU
Two follow-ups to consider: (a) avoid `(rest lits)` in now in unification (assoc-based subst dict copies) and dict
`dl-find-bindings`/`dl-fbs-aux` (uses indexed iteration like the lookups during walks. Future: a per-rule "compiled" body that
membership fix), (b) memoize the per-rule body shape so `(len lits)` pre-resolves arg positions and intern variable indices, then
and accessor calls don't re-walk the list each step. unification can use array slots instead of dict assoc.
## Progress log ## Progress log
_Newest first._ _Newest first._
- 2026-05-08 — Phase 5c perf: indexed `dl-find-bindings`. Replaced
the recursive `(rest lits)` walk with `dl-fb-aux lits db subst i n`
using `nth lits i`. Eliminates O(N²) list-copy per body of length
N. chain-15 saturation 25s → 16s; chain-25 finishes in 33s real
(vs. timeout previously). Bumped semi_naive tests: differential
on chain-10, semi-only count on chain-15 (was chain-5/chain-5).
153/153.
- 2026-05-08 — Phase 10 syntactic demo. New `lib/datalog/demo.sx` - 2026-05-08 — Phase 10 syntactic demo. New `lib/datalog/demo.sx`
with three programs over rose-ash-shaped data: federation with three programs over rose-ash-shaped data: federation
(`mutual`, `reachable`, `foaf`), content recommendation (`mutual`, `reachable`, `foaf`), content recommendation