coop/rose-ash
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Honest test suite: 424/831 (51%) — all tests run, timeouts fail visibly

Browse Source 
Rewrote test architecture: deferred execution. Tests register thunks during
file load (try-call redefined to append to _test-registry), then the
Playwright loop runs each individually with 3s timeout via Promise.race.
Hanging tests (parser infinite loops) fail with TIMEOUT and trigger page
reboot. No tests are hidden or skipped.

Fixed generator: proper quote escaping for HS sources with embedded quotes,
sanitized comments to avoid SX parser special chars.

831 tests registered, 424 pass, 407 fail honestly:
- 22 perfect categories (empty, dialog, morph, default, reset, scroll, etc.)
- Major gaps: if 0/19, wait 0/7, take 0/12, repeat 2/30, set 4/25
- Timeout failures from parser hangs on unsupported syntax

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
giles
2026-04-10 07:54:01 +00:00
parent 23c88cd1e5
commit 737964be89
3 changed files with 1485 additions and 1198 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
tests/playwright/generate-sx-tests.py
View File

@@ -106,7 +106,9 @@ def parse_action(action):
continue
# Skip unrecognized
exprs.append(f';; SKIP action: {part[:60]}')
# Sanitize comment — remove all chars that SX parser treats specially
safe = re.sub(r'[\'\"$@`(),;\\#\[\]{}]', '_', part[:40])
exprs.append(f';; SKIP action: {safe}')
return exprs
@@ -235,7 +237,7 @@ def check_to_sx(check):
return f'(assert (not (dom-has-attr? {r} "{key}")))'
elif typ == 'computedStyle':
# Can't reliably test computed styles in sandbox
return f';; SKIP computed style: {name}.{key} == {val}'
return f';; SKIP computed style: {name}.{key}'
elif typ == 'noParent':
return f'(assert (nil? (dom-parent {r})))'
elif typ == 'hasParent':
@@ -243,7 +245,7 @@ def check_to_sx(check):
elif typ == 'value':
return f'(assert= "{key}" (dom-get-prop {r} "value"))'
else:
return f';; SKIP check: {typ} {name} {key} {val}'
return f';; SKIP check: {typ} {name}'
def generate_test(test, idx):
"""Generate SX deftest for an upstream test."""
@@ -293,22 +295,23 @@ def generate_test(test, idx):
lines.append(f' (dom-add-class {var} "{cls}")')
if el['hs']:
hs_val = el['hs']
# Clean up the HS source for SX string embedding
hs_val = hs_val.replace('\\', '').replace('\n', ' ').strip()
hs_val = hs_val.replace('\\', '').replace('\n', ' ').replace('\t', ' ').strip()
if not hs_val:
continue
# Double quotes in HS source → use single-quoted SX string
if '"' in hs_val:
# Can't embed in SX string — wrap in a comment and skip activation
lines.append(f' ;; HS source contains quotes: {hs_val[:60]}')
# Skip malformed values (HTML parser artifacts starting/ending with quotes)
if hs_val.startswith('"') or hs_val.endswith('"'):
lines.append(f' ;; HS source has bare quotes — HTML parse artifact')
continue
lines.append(f' (dom-set-attr {var} "_" "{hs_val}")')
# Escape for SX double-quoted string
hs_escaped = hs_val.replace('\\', '\\\\').replace('"', '\\"')
lines.append(f' (dom-set-attr {var} "_" "{hs_escaped}")')
all_hs_sources.add(hs_escaped)
for aname, aval in el['attrs'].items():
# Skip attributes with characters that can't be embedded in SX strings
if '\\' in aval or '\n' in aval or aname.startswith('[') or '"' in aval:
if '\\' in aval or '\n' in aval or aname.startswith('['):
lines.append(f' ;; SKIP attr {aname} (contains special chars)')
continue
lines.append(f' (dom-set-attr {var} "{aname}" "{aval}")')
aval_escaped = aval.replace('"', '\\"')
lines.append(f' (dom-set-attr {var} "{aname}" "{aval_escaped}")')
lines.append(f' (dom-append (dom-body) {var})')
if el['hs']:
lines.append(f' (hs-activate! {var})')