datalog: dl-magic-query shape validator (255/255)
Some checks failed
Test, Build, and Deploy / test-build-deploy (push) Failing after 44s

Bug: dl-magic-query crashed with cryptic "rest: 1 list arg" when
the goal argument was a string, number, or arbitrary dict. The
first thing the function does is dl-rel-name + dl-adorn-goal,
both of which assume a positive-literal list shape.

Fix: explicit shape check up front. A goal must be a non-empty
list whose first element is a symbol. Otherwise raise with a
clear diagnostic. Built-in / aggregate / negation dispatch (the
fall-back to dl-query) is unchanged.

2 new magic tests cover string and bare-dict goal rejection.
This commit is contained in:
2026-05-10 21:13:30 +00:00
parent 96c9e90743
commit 69a53ece43
4 changed files with 29 additions and 6 deletions

View File

@@ -242,6 +242,24 @@
(= (len semi) (len magic))))
true)
;; Shape validation: dl-magic-query rejects non-list / non-
;; dict goal shapes cleanly rather than crashing in `rest`.
(dl-mt-test! "magic rejects string goal"
(let ((threw false))
(do
(guard (e (#t (set! threw true)))
(dl-magic-query (dl-make-db) "foo"))
threw))
true)
(dl-mt-test! "magic rejects bare dict goal"
(let ((threw false))
(do
(guard (e (#t (set! threw true)))
(dl-magic-query (dl-make-db) {:foo "bar"}))
threw))
true)
;; 3-stratum program under magic — distinct rule heads at
;; strata 0/1/2 must all rewrite via the worklist.
(dl-mt-test! "magic 3-stratum program"