coop/rose-ash
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix JIT closure scoping: use vm_env_ref not caller's globals

Browse Source 
When the VM called a JIT-compiled lambda, it passed vm.globals
(the caller's global env) instead of cl.vm_env_ref (the closure's
captured env that was merged at compile time). Closure-captured
variables like code-tokens from island let/letrec scopes were
invisible at runtime, causing "Undefined symbol" errors that
cascaded to disable render-to-html globally.

Fix: call_closure uses cl.vm_env_ref at both call sites (cached
bytecode and fresh compilation).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
giles
2026-03-25 16:11:41 +00:00
parent 3e80f371da
commit 2775ce935b
2 changed files with 73 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
sx/sx/home-stepper.sx
View File

@@ -219,23 +219,17 @@
;; Component expressions handled by lake's reactive render
nil))
(swap! step-idx inc)
(update-code-highlight)))))
(rebuild-preview (fn (target)
(let ((container (get-preview)))
(when container
(dom-set-prop container "innerHTML" "")
(let ((expr (steps-to-preview (deref steps) target)))
(when expr
(let ((dom (render-to-dom expr (get-render-env nil) nil)))
(when dom (dom-append container dom)))))
(set-stack (list container))))))
(update-code-highlight)
(set-cookie "sx-home-stepper" (freeze-to-sx "home-stepper")))))
(do-back (fn ()
(when (> (deref step-idx) 0)
(let ((target (- (deref step-idx) 1)))
(rebuild-preview target)
(reset! step-idx target)
(update-code-highlight)
(set-cookie "sx-home-stepper" (freeze-to-sx "home-stepper"))))))))
(let ((target (- (deref step-idx) 1))
(container (get-preview)))
(when container (dom-set-prop container "innerHTML" ""))
(set-stack (list (get-preview)))
(reset! step-idx 0)
(for-each (fn (_) (do-step)) (slice (deref steps) 0 target))
(set-cookie "sx-home-stepper" (freeze-to-sx "home-stepper")))))))
;; Freeze scope for persistence — same mechanism, cookie storage
(freeze-scope "home-stepper" (fn ()
(freeze-signal "step" step-idx)))
@@ -260,7 +254,13 @@
(let ((_eff (effect (fn ()
(schedule-idle (fn ()
(build-code-dom)
(rebuild-preview (deref step-idx))
(let ((preview (get-preview)))
(when preview (dom-set-prop preview "innerHTML" "")))
(batch (fn ()
(let ((target (deref step-idx)))
(reset! step-idx 0)
(set-stack (list (get-preview)))
(for-each (fn (_) (do-step)) (slice (deref steps) 0 target)))))
(update-code-highlight)
(run-post-render-hooks)))))))
(div :class "space-y-4"
@@ -282,9 +282,7 @@
(deref code-tokens)))
;; Controls
(div :class "flex items-center justify-center gap-2 md:gap-3"
(button :on-click (fn (e)
(do-back)
(set-cookie "sx-home-stepper" (freeze-to-sx "home-stepper")))
(button :on-click (fn (e) (do-back))
:class (str "px-2 py-1 rounded text-3xl "
(if (> (deref step-idx) 0)
"text-stone-600 hover:text-stone-800 hover:bg-stone-100"
@@ -292,9 +290,7 @@
"\u25c0")
(span :class "text-sm text-stone-500 font-mono tabular-nums"
(deref step-idx) " / " (len (deref steps)))
(button :on-click (fn (e)
(do-step)
(set-cookie "sx-home-stepper" (freeze-to-sx "home-stepper")))
(button :on-click (fn (e) (do-step))
:class (str "px-2 py-1 rounded text-3xl "
(if (< (deref step-idx) (len (deref steps)))
"text-violet-600 hover:text-violet-800 hover:bg-violet-50"
@@ -303,6 +299,6 @@
;; Live preview — shows partial result up to current step.
;; Same SX rendered by server (HTML) and client (DOM).
(lake :id "home-preview"
(steps-to-preview (deref steps) (deref step-idx))))))
(steps-to-preview (deref steps) (deref step-idx))))))))