mk: phase 2A — streams + ==/conj/disj, 34 new tests

lib/minikanren/stream.sx: mzero/unit/mk-mplus/mk-bind/stream-take. Three
stream shapes (empty, mature list, immature thunk). mk-mplus suspends and
swaps on a paused-left for fair interleaving (Reasoned Schemer style).

lib/minikanren/goals.sx: succeed/fail/==/==-check + conj2/disj2 +
variadic mk-conj/mk-disj. ==-check is the opt-in occurs-checked variant.

Forced-rename note: SX has a host primitive `bind` that silently shadows
user-level defines, so all stream/goal operators are mk-prefixed. Recorded
in feedback memory.

82/82 tests cumulative (48 unify + 34 goals).

lib/minikanren/goals.sx

@@ -0,0 +1,58 @@
+;; lib/minikanren/goals.sx — Phase 2 piece B: core goals.
+;;
+;; A goal is a function (fn (s) → stream-of-substitutions).
+;; Goals built here:
+;;   succeed         — always returns (unit s)
+;;   fail            — always returns mzero
+;;   ==              — unifies two terms; succeeds with a singleton, else fails
+;;   ==-check        — opt-in occurs-checked equality
+;;   conj2 / mk-conj — sequential conjunction of goals
+;;   disj2 / mk-disj — interleaved disjunction of goals (raw — `conde` adds
+;;                     the implicit-conj-per-clause sugar in a later commit)
+
+(define succeed (fn (s) (unit s)))
+
+(define fail (fn (s) mzero))
+
+(define
+  ==
+  (fn
+    (u v)
+    (fn
+      (s)
+      (let ((s2 (mk-unify u v s))) (if (= s2 nil) mzero (unit s2))))))
+
+(define
+  ==-check
+  (fn
+    (u v)
+    (fn
+      (s)
+      (let ((s2 (mk-unify-check u v s))) (if (= s2 nil) mzero (unit s2))))))
+
+(define conj2 (fn (g1 g2) (fn (s) (mk-bind (g1 s) g2))))
+
+(define disj2 (fn (g1 g2) (fn (s) (mk-mplus (g1 s) (g2 s)))))
+
+;; Fold goals in a list. (mk-conj-list ()) ≡ succeed; (mk-disj-list ()) ≡ fail.
+(define
+  mk-conj-list
+  (fn
+    (gs)
+    (cond
+      ((empty? gs) succeed)
+      ((empty? (rest gs)) (first gs))
+      (:else (conj2 (first gs) (mk-conj-list (rest gs)))))))
+
+(define
+  mk-disj-list
+  (fn
+    (gs)
+    (cond
+      ((empty? gs) fail)
+      ((empty? (rest gs)) (first gs))
+      (:else (disj2 (first gs) (mk-disj-list (rest gs)))))))
+
+(define mk-conj (fn (&rest gs) (mk-conj-list gs)))
+
+(define mk-disj (fn (&rest gs) (mk-disj-list gs)))

lib/minikanren/stream.sx

@@ -0,0 +1,58 @@
+;; lib/minikanren/stream.sx — Phase 2 piece A: lazy streams of substitutions.
+;;
+;; Three stream shapes per The Reasoned Schemer (chapter 9):
+;;   mzero     — empty stream  (the SX empty list)
+;;   mature    — '(s . rest)   (a proper SX list of substitutions)
+;;   immature  — a thunk        (an SX lambda taking zero args, returns a stream)
+;;
+;; Immature thunks are how miniKanren keeps search lazy and supports
+;; interleaved disjunction without diverging on left-recursive relations.
+;; SX has plain function closures, so a thunk is just (fn () body).
+;;
+;; Names are mk-prefixed: SX has a host primitive `bind` that would shadow
+;; a user-level definition.
+
+(define mzero (list))
+
+(define unit (fn (s) (list s)))
+
+(define stream-pause? (fn (s) (and (not (list? s)) (callable? s))))
+
+;; mk-mplus — interleave two streams. If the first is mature/empty we use it
+;; directly; if it is paused, we suspend and swap so the other stream gets
+;; explored fairly (Reasoned Schemer "interleave").
+(define
+  mk-mplus
+  (fn
+    (s1 s2)
+    (cond
+      ((empty? s1) s2)
+      ((stream-pause? s1) (fn () (mk-mplus s2 (s1))))
+      (:else (cons (first s1) (mk-mplus (rest s1) s2))))))
+
+;; mk-bind — apply goal g to every substitution in stream s, mk-mplus-ing results.
+(define
+  mk-bind
+  (fn
+    (s g)
+    (cond
+      ((empty? s) mzero)
+      ((stream-pause? s) (fn () (mk-bind (s) g)))
+      (:else (mk-mplus (g (first s)) (mk-bind (rest s) g))))))
+
+;; stream-take — force up to n results out of a (possibly lazy) stream.
+;; n = -1 to take all (used by run*).
+(define
+  stream-take
+  (fn
+    (n s)
+    (cond
+      ((= n 0) (list))
+      ((empty? s) (list))
+      ((stream-pause? s) (stream-take n (s)))
+      (:else
+        (cons
+          (first s)
+          (stream-take
+            (if (= n -1) -1 (- n 1))
+            (rest s)))))))

lib/minikanren/tests/goals.sx

@@ -0,0 +1,216 @@
+;; lib/minikanren/tests/goals.sx — Phase 2 tests for stream.sx + goals.sx.
+;;
+;; Loaded after: lib/guest/match.sx, lib/minikanren/unify.sx,
+;;               lib/minikanren/stream.sx, lib/minikanren/goals.sx.
+;; Reuses the mk-test* counters from tests/unify.sx — load that first to
+;; accumulate, or call mk-tests-run! after this file alone for fresh totals.
+
+;; --- stream-take base cases ---
+
+(mk-test
+  "stream-take-zero-from-mature"
+  (stream-take 0 (list 1 2 3))
+  (list))
+
+(mk-test "stream-take-from-empty" (stream-take 5 mzero) (list))
+
+(mk-test
+  "stream-take-mature-list"
+  (stream-take 5 (list 1 2 3))
+  (list 1 2 3))
+
+(mk-test
+  "stream-take-fewer-than-available"
+  (stream-take 2 (list 10 20 30))
+  (list 10 20))
+
+(mk-test
+  "stream-take-all-with-neg-1"
+  (stream-take -1 (list 1 2 3 4))
+  (list 1 2 3 4))
+
+;; --- stream-take forces immature thunks ---
+
+(mk-test
+  "stream-take-forces-thunk"
+  (stream-take 3 (fn () (list "a" "b" "c")))
+  (list "a" "b" "c"))
+
+(mk-test
+  "stream-take-forces-nested-thunks"
+  (stream-take
+    3
+    (fn () (fn () (list 1 2 3))))
+  (list 1 2 3))
+
+;; --- mk-mplus interleaves ---
+
+(mk-test
+  "mplus-empty-left"
+  (mk-mplus mzero (list 1 2))
+  (list 1 2))
+(mk-test
+  "mplus-empty-right"
+  (mk-mplus (list 1 2) mzero)
+  (list 1 2))
+
+(mk-test
+  "mplus-mature-mature"
+  (mk-mplus (list 1 2) (list 3 4))
+  (list 1 2 3 4))
+
+(mk-test
+  "mplus-with-paused-left-swaps"
+  (stream-take 4 (mk-mplus (fn () (list "a" "b")) (list "c" "d")))
+  (list "c" "d" "a" "b"))
+
+;; --- mk-bind ---
+
+(mk-test "bind-empty-stream" (mk-bind mzero (fn (s) (unit s))) (list))
+
+(mk-test
+  "bind-singleton-identity"
+  (mk-bind (list 5) (fn (x) (list x)))
+  (list 5))
+
+(mk-test
+  "bind-flat-multi"
+  (mk-bind
+    (list 1 2)
+    (fn (x) (list x (* x 10))))
+  (list 1 10 2 20))
+
+(mk-test
+  "bind-fail-prunes-some"
+  (mk-bind
+    (list 1 2 3)
+    (fn (x) (if (= x 2) (list) (list x))))
+  (list 1 3))
+
+;; --- core goals: succeed / fail ---
+
+(mk-test "succeed-yields-singleton" (succeed empty-s) (list empty-s))
+
+(mk-test "fail-yields-mzero" (fail empty-s) (list))
+
+;; --- == ---
+
+(mk-test
+  "eq-ground-success"
+  (mk-unified? (first ((== 1 1) empty-s)))
+  true)
+
+(mk-test "eq-ground-failure" ((== 1 2) empty-s) (list))
+
+(mk-test
+  "eq-binds-var"
+  (let
+    ((x (mk-var "x")))
+    (mk-walk x (first ((== x 7) empty-s))))
+  7)
+
+(mk-test
+  "eq-list-success"
+  (let
+    ((x (mk-var "x")))
+    (mk-walk x (first ((== x (list 1 2)) empty-s))))
+  (list 1 2))
+
+(mk-test
+  "eq-list-mismatch-fails"
+  ((== (list 1 2) (list 1 3)) empty-s)
+  (list))
+
+;; --- conj2 / mk-conj ---
+
+(mk-test
+  "conj2-both-bind"
+  (let
+    ((x (mk-var "x")) (y (mk-var "y")))
+    (let
+      ((s (first ((conj2 (== x 1) (== y 2)) empty-s))))
+      (list (mk-walk x s) (mk-walk y s))))
+  (list 1 2))
+
+(mk-test
+  "conj2-conflict-empty"
+  (let
+    ((x (mk-var "x")))
+    ((conj2 (== x 1) (== x 2)) empty-s))
+  (list))
+
+(mk-test "conj-empty-is-succeed" ((mk-conj) empty-s) (list empty-s))
+
+(mk-test
+  "conj-single-is-goal"
+  (let
+    ((x (mk-var "x")))
+    (mk-walk x (first ((mk-conj (== x 99)) empty-s))))
+  99)
+
+(mk-test
+  "conj-three-bindings"
+  (let
+    ((x (mk-var "x")) (y (mk-var "y")) (z (mk-var "z")))
+    (let
+      ((s (first ((mk-conj (== x 1) (== y 2) (== z 3)) empty-s))))
+      (list (mk-walk x s) (mk-walk y s) (mk-walk z s))))
+  (list 1 2 3))
+
+;; --- disj2 / mk-disj ---
+
+(mk-test
+  "disj2-both-succeed"
+  (let
+    ((q (mk-var "q")))
+    (let
+      ((res (stream-take 5 ((disj2 (== q 1) (== q 2)) empty-s))))
+      (map (fn (s) (mk-walk q s)) res)))
+  (list 1 2))
+
+(mk-test
+  "disj2-fail-or-succeed"
+  (let
+    ((q (mk-var "q")))
+    (let
+      ((res (stream-take 5 ((disj2 fail (== q 5)) empty-s))))
+      (map (fn (s) (mk-walk q s)) res)))
+  (list 5))
+
+(mk-test "disj-empty-is-fail" ((mk-disj) empty-s) (list))
+
+(mk-test
+  "disj-three-clauses"
+  (let
+    ((q (mk-var "q")))
+    (let
+      ((res (stream-take 5 ((mk-disj (== q "a") (== q "b") (== q "c")) empty-s))))
+      (map (fn (s) (mk-walk q s)) res)))
+  (list "a" "b" "c"))
+
+;; --- conj/disj nesting (distributivity check) ---
+
+(mk-test
+  "disj-of-conj"
+  (let
+    ((x (mk-var "x")) (y (mk-var "y")))
+    (let
+      ((res (stream-take 5 ((mk-disj (mk-conj (== x 1) (== y 2)) (mk-conj (== x 3) (== y 4))) empty-s))))
+      (map (fn (s) (list (mk-walk x s) (mk-walk y s))) res)))
+  (list (list 1 2) (list 3 4)))
+
+;; --- ==-check (occurs-checked equality goal) ---
+
+(mk-test
+  "eq-check-no-occurs-fails"
+  (let ((x (mk-var "x"))) ((==-check x (list 1 x)) empty-s))
+  (list))
+
+(mk-test
+  "eq-check-no-occurs-non-occurring-succeeds"
+  (let
+    ((x (mk-var "x")))
+    (mk-walk x (first ((==-check x 5) empty-s))))
+  5)
+
+(mk-tests-run!)