art-dag/mono
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix register_sx_layout: use async_eval_slot_to_sx to expand component bodies

Browse Source 
async_eval_to_sx serializes component calls without expanding their bodies,
so free variables from _ctx_to_env were passed through as unresolved symbols
to the client. Switch to async_eval_slot_to_sx which expands the top-level
component body server-side, resolving free variables during expansion.

Also inline ~root-header/~root-mobile into layout defcomps rather than using
wrapper defcomps (nested ~component calls in _aser are serialized without
expansion, so wrapper defcomps would still leave free vars unresolved).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
giles
2026-03-04 14:48:43 +00:00
parent 45c5e4a0db
commit e4bfd46c48
2 changed files with 16 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
shared/sx/templates/layout.sx
View File

@@ -146,32 +146,24 @@
(when auth-menu
(div :class "p-3 border-t border-stone-200" auth-menu))))
;; ---------------------------------------------------------------------------
;; Root header/mobile wrappers — read ctx values from env free variables
;; Used by register_sx_layout so .sx defcomps compose without Python
;; ---------------------------------------------------------------------------
(defcomp ~root-header (&key oob)
(~header-row-sx :cart-mini cart-mini :blog-url blog-url :site-title site-title
:app-label app-label :nav-tree nav-tree :auth-menu auth-menu
:nav-panel nav-panel :settings-url settings-url :is-admin is-admin
:oob oob))
(defcomp ~root-mobile ()
(~mobile-root-nav :nav-tree nav-tree :auth-menu auth-menu))
;; ---------------------------------------------------------------------------
;; Built-in layout defcomps — used by register_sx_layout("root", ...)
;; Free variables (cart-mini, blog-url, etc.) come from _ctx_to_env().
;; ---------------------------------------------------------------------------
(defcomp ~layout-root-full ()
(~root-header))
(~header-row-sx :cart-mini cart-mini :blog-url blog-url :site-title site-title
:app-label app-label :nav-tree nav-tree :auth-menu auth-menu
:nav-panel nav-panel :settings-url settings-url :is-admin is-admin))
(defcomp ~layout-root-oob ()
(~oob-header-sx :parent-id "root-header-child" :row (~root-header)))
(~oob-header-sx :parent-id "root-header-child"
:row (~header-row-sx :cart-mini cart-mini :blog-url blog-url :site-title site-title
:app-label app-label :nav-tree nav-tree :auth-menu auth-menu
:nav-panel nav-panel :settings-url settings-url :is-admin is-admin)))
(defcomp ~layout-root-mobile ()
(~root-mobile))
(~mobile-root-nav :nav-tree nav-tree :auth-menu auth-menu))
(defcomp ~error-content (&key errnum message image)
(div :class "text-center p-8 max-w-lg mx-auto"