"""
Tests for run artifacts data structure.

Bug found 2026-01-12: runs/detail.html template expects artifact.cid
but the route provides artifact.hash, causing UndefinedError.
"""

import pytest
from pathlib import Path


class TestArtifactDataStructure:
    """Tests for artifact dict keys matching template expectations."""

    def test_template_expects_cid_key(self) -> None:
        """Template uses artifact.cid - verify this expectation."""
        template_path = Path('/home/giles/art/art-celery/app/templates/runs/detail.html')
        content = template_path.read_text()

        # Template uses artifact.cid in multiple places
        assert 'artifact.cid' in content, "Template should reference artifact.cid"

    def test_run_service_artifacts_have_cid_key(self) -> None:
        """
        Regression test: get_run_artifacts must return dicts with 'cid' key.

        Bug: Service returned artifacts with 'hash' key but template expected 'cid'.
        Fix: Changed service to use 'cid' key for consistency.
        """
        # Read the run_service.py file and check it uses 'cid' not 'hash'
        service_path = Path('/home/giles/art/art-celery/app/services/run_service.py')
        content = service_path.read_text()

        # Find the get_artifact_info function and check it returns 'cid'
        # The function should have: "cid": cid, not "hash": cid
        assert '"cid": cid' in content or "'cid': cid" in content, \
            "get_run_artifacts should return artifacts with 'cid' key, not 'hash'"

    def test_router_artifacts_have_cid_key(self) -> None:
        """
        Regression test: inline artifact creation in router must use 'cid' key.

        Bug: Router created artifacts with 'hash' key but template expected 'cid'.
        """
        router_path = Path('/home/giles/art/art-celery/app/routers/runs.py')
        content = router_path.read_text()

        # Check that artifacts.append uses 'cid' key
        # Should have: "cid": output_cid, not "hash": output_cid
        # Count occurrences of the patterns
        hash_pattern_count = content.count('"hash": output_cid')
        cid_pattern_count = content.count('"cid": output_cid')

        assert cid_pattern_count > 0, \
            "Router should create artifacts with 'cid' key"
        assert hash_pattern_count == 0, \
            "Router should not use 'hash' key for artifacts (template expects 'cid')"