Fix IPFS upload: sync instead of background task
The background IPFS upload task was running on workers that don't have the file locally, causing uploads to fail silently. Now uploads go to IPFS synchronously so the IPFS CID is available immediately. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -554,13 +554,13 @@ class CacheService:
|
||||
# Detect media type (video/image/audio) before moving file
|
||||
media_type = detect_media_type(tmp_path)
|
||||
|
||||
# Store locally first (skip_ipfs=True for fast response)
|
||||
# IPFS upload happens in background
|
||||
cached, ipfs_cid = self.cache.put(tmp_path, node_type="upload", move=True, skip_ipfs=True)
|
||||
cid = cached.cid # Use local hash since we skipped IPFS
|
||||
# Store locally AND upload to IPFS synchronously
|
||||
# This ensures the IPFS CID is available immediately for distributed access
|
||||
cached, ipfs_cid = self.cache.put(tmp_path, node_type="upload", move=True, skip_ipfs=False)
|
||||
cid = ipfs_cid or cached.cid # Prefer IPFS CID, fall back to local hash
|
||||
|
||||
# Save to database with media category type
|
||||
await self.db.create_cache_item(cid, ipfs_cid) # ipfs_cid is None initially
|
||||
await self.db.create_cache_item(cached.cid, ipfs_cid)
|
||||
await self.db.save_item_metadata(
|
||||
cid=cid,
|
||||
actor_id=actor_id,
|
||||
@@ -568,13 +568,10 @@ class CacheService:
|
||||
filename=filename
|
||||
)
|
||||
|
||||
# Queue background IPFS upload
|
||||
try:
|
||||
from tasks.ipfs_upload import upload_to_ipfs
|
||||
upload_to_ipfs.delay(cid, actor_id)
|
||||
logger.info(f"Queued background IPFS upload for {cid[:16]}...")
|
||||
except Exception as e:
|
||||
logger.warning(f"Failed to queue IPFS upload (will retry manually): {e}")
|
||||
if ipfs_cid:
|
||||
logger.info(f"Uploaded to IPFS: {ipfs_cid[:16]}...")
|
||||
else:
|
||||
logger.warning(f"IPFS upload failed, using local hash: {cid[:16]}...")
|
||||
|
||||
return cid, ipfs_cid, None
|
||||
except Exception as e:
|
||||
|
||||
Reference in New Issue
Block a user